From owner-svn-src-head@freebsd.org Fri Jan 22 15:21:44 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 897FCA8D313; Fri, 22 Jan 2016 15:21:44 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from smtp.hungerhost.com (smtp.hungerhost.com [216.38.51.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 68B6F1D56; Fri, 22 Jan 2016 15:21:44 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from lawn-143-215-96-150.lawn.gatech.edu ([143.215.96.150]:52786) by vps.hungerhost.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.86) (envelope-from ) id 1aMdWw-0000ph-Tb; Fri, 22 Jan 2016 10:21:42 -0500 From: "George Neville-Neil" To: "Lawrence Stewart" Cc: "Gleb Smirnoff" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r294535 - in head/sys/netinet: . cc tcp_stacks Date: Fri, 22 Jan 2016 10:21:40 -0500 Message-ID: <058BD5D5-C1AC-45DA-B6BE-2EDC4D64F67F@neville-neil.com> In-Reply-To: <56A1D6B2.1010406@freebsd.org> References: <201601212234.u0LMYpKT009948@repo.freebsd.org> <56A1D6B2.1010406@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Mailer: MailMate (1.9.3r5187) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vps.hungerhost.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - neville-neil.com X-Get-Message-Sender-Via: vps.hungerhost.com: authenticated_id: gnn@neville-neil.com X-Authenticated-Sender: vps.hungerhost.com: gnn@neville-neil.com X-Source: X-Source-Args: X-Source-Dir: X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jan 2016 15:21:44 -0000 On 22 Jan 2016, at 2:13, Lawrence Stewart wrote: > Hi Gleb, > > On 01/22/16 09:34, Gleb Smirnoff wrote: >> Author: glebius >> Date: Thu Jan 21 22:34:51 2016 >> New Revision: 294535 >> URL: https://svnweb.freebsd.org/changeset/base/294535 >> >> Log: >> - Rename cc.h to more meaningful tcp_cc.h. > > As a bit of historical context, the naming was intentionally protocol > agnostic because it was originally hoped that the CC framework could > be > shared between multiple CC aware transports, and the design went to > some > lengths to accommodate that possibility (e.g. the ccv_container union > in > struct cc_var). SCTP was the obvious potential in tree consumer at the > time, and other protocols like DCCP were considered as well. > > This hasn't come about to date, but I'm not sure what value is > obtained > from your rename change unless we decide to completely give up on > shared > CC and if we do that, this change doesn't go far enough and we can > further simplify the framework to make it entirely TCP specific e.g. > we > should probably do away with struct cc_var. > > I'd argue in favour of reverting the rename and if you're gung ho > about > making the framework TCP specific, we can start a public discussion > about what that should look like. > I actually was wondering about this as well. I think it ought to be reverted to agnostic. Best, George