From nobody Tue Apr 28 19:56:38 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g4rmQ5Xmzz6c1r1 for ; Tue, 28 Apr 2026 19:56:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g4rmQ4ldRz3G1g for ; Tue, 28 Apr 2026 19:56:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777406198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZRuiVOenumgkolLrD8cox9jFTQQXR43oRI4Ega0LRr4=; b=DmAyJWmGFFOSx/QTrw+y4krNtSMM42aDzmcgt6IBnr2XmGdHk907zxFx3lr9aPesd8F2n3 oWcnZ+HZkERCBv1w8DezDgEokZDQlFD93YmzhW9ICNYWi+bed3URlK93rTONhJNYMQRMrQ c9lo2Ua3m4+xUQm+68P3krTJQtTB+64rnk6nXMr9HOsIYytbcCrHmNPcrEJYlbJDOoNrHB ls+lSQ9D3pM7O+exq6G6ujuPeSm2uNoRPU6KKFYLXbdtNOUT5dX57qUDVEc3rwCdgVW7+J Q08O7ZMaG3IItIV142s+Iz1le+s5aDK4iygu6qYyQdEvQcG0Om4z97fnwCgGhA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777406198; a=rsa-sha256; cv=none; b=RmTDNsxyC2606bIO7WqGEipSJcdZfpNto1BtKStATRWc8hjQ51lldDrky1AWWTH6WFcQo7 JBaFPvHHWFmBW0gwKB//YlT60preybqAmiHenLNFtc0omYQKhkEHs5oix64tkqaYxbh7XH Vqzgzm5nObopHuShjh72iq26JE8EZKcKPNKWp3c/E8WIhLithcdER8UIYqj12pHwSRYdq7 Sa1sYP5NR6IsEyNPLsVOBh5TCoxnjg5EsAbcBcZkqEKJaJRs3haXTKnp97g6lP+MLeZEoS OLuOKdYbwGKBCCGJyn1K2jdFVexnjMyeltGTyebr21NQSr/tuLpZ9mNJJlgQCA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777406198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZRuiVOenumgkolLrD8cox9jFTQQXR43oRI4Ega0LRr4=; b=Jg4mfNtLgF1MJ42l6HW7B4xvB4zgeh4obO4cvfiCm195g5v0xk1sHP3tHrqIacVgr/GKv2 BxI7eAGWW2JKIWojTEPQh9ntepuVzCHsvlBsftJLbru5rqBNc4z69X+vco6cRQJnxpz7Q0 HPmnaOQwV244XFiD5frZ0hew7l1qF9wWChk4+sWsV+czMK/7DBoloIBXQ036YPkYLS01rX EQnnR7Un+LzGtcoolgNNVl11nqeKdGycPZ99sntinPH9QBpAM7j86Py3KkzPb8hCzBKoIK 4j6tdvBfiZyU3w6ZAQOXhF8z6yunQX2T1YNQcDXRNJrnCEZb7hRz1FM40KGqqQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g4rmQ4Lynz177C for ; Tue, 28 Apr 2026 19:56:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 365c0 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 28 Apr 2026 19:56:38 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Lexi Winter Subject: git: 66f55b90b6bc - stable/15 - boot1.chrp: Improve comment for the SLOF hack List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ivy X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 66f55b90b6bcbbf3c26b2da7f56d17052e39018f Auto-Submitted: auto-generated Date: Tue, 28 Apr 2026 19:56:38 +0000 Message-Id: <69f110f6.365c0.22666958@gitrepo.freebsd.org> The branch stable/15 has been updated by ivy: URL: https://cgit.FreeBSD.org/src/commit/?id=66f55b90b6bcbbf3c26b2da7f56d17052e39018f commit 66f55b90b6bcbbf3c26b2da7f56d17052e39018f Author: Lexi Winter AuthorDate: 2026-04-17 16:56:33 +0000 Commit: Lexi Winter CommitDate: 2026-04-28 19:56:21 +0000 boot1.chrp: Improve comment for the SLOF hack Since this original comment was written, the actual issue in SLOF was diagnosed and documented in commit 424089a0fc, which fixed it for loader(8). Update the comment in boot1 to be more informative to future readers. MFC after: 3 days Reviewed by: jhibbits, adrian Sponsored by: https://www.patreon.com/bsdivy Differential Revision: https://reviews.freebsd.org/D56470 (cherry picked from commit eb0279550d52962241b4178101cd7f7d732eb682) --- stand/powerpc/boot1.chrp/boot1.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/stand/powerpc/boot1.chrp/boot1.c b/stand/powerpc/boot1.chrp/boot1.c index 1a546f3473e2..1bb06bf82983 100644 --- a/stand/powerpc/boot1.chrp/boot1.c +++ b/stand/powerpc/boot1.chrp/boot1.c @@ -102,14 +102,11 @@ ofwh_t bootdevh; ofwh_t stdinh, stdouth; /* - * Note about the entry point: + * Our entrypoint. * - * For some odd reason, the first page of the load appears to have trouble - * when entering in LE. The first five instructions decode weirdly. - * I suspect it is some cache weirdness between the ELF headers and .text. - * - * Ensure we have a gap between the start of .text and the entry as a - * workaround. + * A bug in the SLOF shipped with some versions of QEMU causes the first + * 32 bytes of .text to be wrongly byte-swapped when loading LE programs. + * As a workaround, we add some padding at the start of the text section. */ __asm(" \n\ .data \n\ @@ -118,7 +115,7 @@ stack: \n\ .space 16384 \n\ \n\ .text \n\ - /* SLOF cache hack */ \n\ + /* SLOF workaround */ \n\ .space 4096 \n\ .globl _start \n\ _start: \n\