Date: Wed, 3 Feb 2016 15:30:08 +0100 From: Guido Falsi <madpilot@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r407901 - in head/net-mgmt/collectd5: . files Message-ID: <56B20EF0.1080606@FreeBSD.org> In-Reply-To: <20160203132636.GB24872@FreeBSD.org> References: <201602022308.u12N8kud098510@repo.freebsd.org> <20160203065658.GA77151@FreeBSD.org> <56B1BFBD.7030301@FreeBSD.org> <20160203132636.GB24872@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 02/03/16 14:26, Alexey Dokuchaev wrote: > On Wed, Feb 03, 2016 at 09:52:13AM +0100, Guido Falsi wrote: >> On 02/03/16 07:56, Alexey Dokuchaev wrote: >>> On Tue, Feb 02, 2016 at 11:08:46PM +0000, Guido Falsi wrote: >>>> New Revision: 407901 >>>> URL: https://svnweb.freebsd.org/changeset/ports/407901 >>>> >>>> Log: >>>> - Update to 5.5.1 >>>> - Mark MONGODB option as BROKEN >>> >>> Commit log does not explain what's exactly broken, which makes it >>> (the log) pretty useless. :( >> >> That information is in the PR, which is referenced by the commit >> message, I thought that could be enough. > > At least a few words should be made part of the commit log; bugzilla could > be down or something else. While it's OK to omit "Submitted by" because it > included in the PR, technical bits of information related to the commit are > better be part of the log. I understand, I'll be more careful in the future. In this case the option makes the port fail to build due to API changes in MongoDB. -- Guido Falsi <madpilot@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56B20EF0.1080606>