Date: Sun, 13 Mar 2011 12:16:59 -0700 From: Artem Belevich <fbsdlist@src.cx> To: Alexander Leidinger <Alexander@leidinger.net> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Andriy Gapon <avg@freebsd.org> Subject: Re: svn commit: r219559 - in head/sys: amd64/linux32 compat/freebsd32 i386/linux kern Message-ID: <AANLkTik-OGmmOp2axi7dVOd4aB8Dj8Y_szOLNNqf%2BJCS@mail.gmail.com> In-Reply-To: <20110313141528.000013b1@unknown> References: <201103120851.p2C8phoN010341@svn.freebsd.org> <20110312205719.00004e67@unknown> <AANLkTimOAKLJm10dZAu2SYPeUk3agL_hsv-t7D1UHOj5@mail.gmail.com> <20110313141528.000013b1@unknown>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 13, 2011 at 6:15 AM, Alexander Leidinger <Alexander@leidinger.net> wrote: > On Sat, 12 Mar 2011 22:24:09 -0800 Artem Belevich <fbsdlist@src.cx> > wrote: > >> >> Modified: head/sys/i386/linux/syscalls.master >> >> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 l_h= andler_t handler); } >> >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 voi= d *handler); } >> > >> > What's wrong with l_handler_t? >> >> I don't recall the details, but I believe that the way l_handler_t is >> defined resulted in compilation errors in generated glue code. Glue >> generation code relies on '*' before the argument name in order to >> tell scalars from pointers. l_handler_t was interpreted as a scalar >> and on i386 where l_handler_t is a pointer, it produced compilation >> warning. > > What about documenting it with a comment nearby? How about this: handle is l_handle_t, but the makesyscalls.sh relies on '*' to tell pointers from scalars when it generates DTrace glue code, so void* had to be used. I don't have commit bit, though. --Artem
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTik-OGmmOp2axi7dVOd4aB8Dj8Y_szOLNNqf%2BJCS>