From owner-freebsd-bugs@FreeBSD.ORG  Mon Jun 30 10:25:02 2014
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 2697DC87
 for <freebsd-bugs@FreeBSD.org>; Mon, 30 Jun 2014 10:25:02 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 0F12C2636
 for <freebsd-bugs@FreeBSD.org>; Mon, 30 Jun 2014 10:25:02 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.8/8.14.8) with ESMTP id s5UAP1wr071593
 for <freebsd-bugs@FreeBSD.org>; Mon, 30 Jun 2014 11:25:01 +0100 (BST)
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 191511] New: opiepasswd segfaults with a seed length > 12
Date: Mon, 30 Jun 2014 10:25:02 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: bin
X-Bugzilla-Version: 10.0-RELEASE
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: mitsururike@gmail.com
X-Bugzilla-Status: Needs Triage
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-191511-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Jun 2014 10:25:02 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191511

            Bug ID: 191511
           Summary: opiepasswd segfaults with a seed length > 12
           Product: Base System
           Version: 10.0-RELEASE
          Hardware: Any
                OS: Any
            Status: Needs Triage
          Severity: Affects Only Me
          Priority: Normal
         Component: bin
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: mitsururike@gmail.com

opiepasswd segfaults with a seed length > 12

" ext" is added to the challenge in libopie/challenge.c but it is not
included in the calculation of the OPIE_CHALLENGE_MAX in opie.h.
Falling back to randomchallenge() and clearing mp causes segfault in
opieatob8().

Environment:
System: FreeBSD 10.0-RELEASE-p4 amd64

How-To-Repeat:
opiepasswd -s 0123456789012

Fix:
--- opie.h.dist    2014-06-30 16:53:37.000000000 +0900
+++ opie.h    2014-06-30 16:53:55.000000000 +0900
@@ -72,8 +72,8 @@
 /* Max length of hash algorithm name (md4/md5) */
 #define OPIE_HASHNAME_MAX 3

-/* Maximum length of a challenge (otp-md? 9999 seed) */
-#define OPIE_CHALLENGE_MAX (4+OPIE_HASHNAME_MAX+1+4+1+OPIE_SEED_MAX)
+/* Maximum length of a challenge (otp-md? 9999 seed ext) */
+#define OPIE_CHALLENGE_MAX (4+OPIE_HASHNAME_MAX+1+4+1+OPIE_SEED_MAX+4)

 /* Maximum length of a response that we allow */
 #define OPIE_RESPONSE_MAX (9+1+19+1+9+OPIE_SEED_MAX+1+19+1+19+1+19)

-- 
You are receiving this mail because:
You are the assignee for the bug.