From owner-cvs-all@FreeBSD.ORG  Sat Apr 24 08:19:39 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id F1D6416A4CE; Sat, 24 Apr 2004 08:19:39 -0700 (PDT)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E246C43D45; Sat, 24 Apr 2004 08:19:39 -0700 (PDT)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id E06435C816; Sat, 24 Apr 2004 08:19:39 -0700 (PDT)
Date: Sat, 24 Apr 2004 08:19:39 -0700
From: Alfred Perlstein <alfred@freebsd.org>
To: Mike Makonnen <mtm@FreeBSD.org>
Message-ID: <20040424151939.GC78817@elvis.mu.org>
References: <200404240938.i3O9cgCB044808@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200404240938.i3O9cgCB044808@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libthr/thread thr_spinlock.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Apr 2004 15:19:40 -0000

* Mike Makonnen <mtm@FreeBSD.org> [040424 02:38] wrote:
> mtm         2004/04/24 02:38:42 PDT
> 
>   FreeBSD src repository
> 
>   Modified files:
>     lib/libthr/thread    thr_spinlock.c 
>   Log:
>   Unconditionaly initialize any spin lock passed to pthread_spin_init(). While
>   makeing sure the spinlock isn't already in use might be a nice feature to
>   have in theory, it's hard to implement in practice since the passed in
>   pointer may not be NULL, but still be an invalid value (i.e. 1..2..3.. etc).

Good call.  Forcing it to be NULL and it might as already be
initialized. :)   (*looks at our kernel API and grumbles*)

>   
>   Revision  Changes    Path
>   1.10      +0 -4      src/lib/libthr/thread/thr_spinlock.c

-- 
- Alfred Perlstein
- Research Engineering Development Inc.
- email: bright@mu.org cell: 408-480-4684