From owner-cvs-all@FreeBSD.ORG Sun Aug 1 20:34:48 2004 Return-Path: <owner-cvs-all@FreeBSD.ORG> Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 671D116A4CE; Sun, 1 Aug 2004 20:34:48 +0000 (GMT) Received: from kientzle.com (h-66-166-149-50.snvacaid.covad.net [66.166.149.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id B2FC043D1F; Sun, 1 Aug 2004 20:34:47 +0000 (GMT) (envelope-from kientzle@freebsd.org) Received: from freebsd.org (p54.kientzle.com [66.166.149.54]) by kientzle.com (8.12.9/8.12.9) with ESMTP id i71KYl90091781; Sun, 1 Aug 2004 13:34:47 -0700 (PDT) (envelope-from kientzle@freebsd.org) Message-ID: <410D53E6.7060406@freebsd.org> Date: Sun, 01 Aug 2004 13:34:46 -0700 From: Tim Kientzle <kientzle@freebsd.org> User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.4) Gecko/20031006 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Peter Jeremy <PeterJeremy@optushome.com.au> References: <200407300414.i6U4ElBw068754@repoman.freebsd.org> <20040730074825.GN3001@cirb503493.alcatel.com.au> In-Reply-To: <20040730074825.GN3001@cirb503493.alcatel.com.au> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit:src/lib/libarchivearchive_read_support_compression_all.c archive_write_set_compression_gzip.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>, <mailto:cvs-all-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/cvs-all> List-Post: <mailto:cvs-all@freebsd.org> List-Help: <mailto:cvs-all-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>, <mailto:cvs-all-request@freebsd.org?subject=subscribe> X-List-Received-Date: Sun, 01 Aug 2004 20:34:48 -0000 Peter Jeremy wrote: > On Fri, 2004-Jul-30 04:14:47 +0000, Tim Kientzle wrote: > >> This will allow the library to be easily ported to systems >> that don't have these libraries. (Of course, it also means >> that clients using the library on such systems will not be >> able to take advantage of the automatic compression format >> detection.) > > > How difficult would it be to detect bzip2/gzip input and produce a > "[bg]zip compression not supported" rather than a generic "this > input looks like garbage" message? Pretty simple. Basically, leave the bid function alone and replace the read function with one that always returns an error. I'll put it on my to-do list. Of course, if someone would like to send me some diffs, it would get done sooner. ;-) Tim