From owner-dev-commits-src-main@freebsd.org Mon May 31 19:51:44 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3E70F64E6BF for ; Mon, 31 May 2021 19:51:44 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Fv5XJ0xwrz4pJp for ; Mon, 31 May 2021 19:51:43 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wm1-f42.google.com with SMTP id o127so6785453wmo.4 for ; Mon, 31 May 2021 12:51:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=0EOwrAVD3LMjXgEoQz+Z4A5vGzP4hrRDslYOm4DR/eI=; b=VnLR2kcEHpVZ/+3KXzpBQdsEzJXtZFJZc2Jyh+P5BRZUZCYMO5DsK2GKsA30/kIa2K xw2PASuR4crURxU5/4Z14kEwNiESEsCFw6VwR2cJXPdeiPzZS6VePTwgraAEQ1HGWsai H9j1CdBEHG4TwNjZ685dusPgN5Th+AipOC1hVWGn9NThtsnHatzW5kWZtx1gNYcdROr+ Mm5TsU+2uciQMbD0Lq7CYHmo9KgvyxUHpxwYGV1YQ9OVXWkjFWHgO675mb7puenQ4nxO +2f0W7U2MunLkiasThA7yWRtZgiVmKBiEnwPT6DBbwDM406hBg1wo4wk6W8BVs8mCrCL ZXpA== X-Gm-Message-State: AOAM532AU7/KhE290OTdqomHtLL64yzzNw6+bJrDwMaWj0fLh4KFr2bl 3su7QlV1HjROwlKTCqM03X7pCHEYiH+Eiw== X-Google-Smtp-Source: ABdhPJwJ+DW+02g8hgsuVBtSyFZbza0l2w987FecxQu1EA0Rtx02hCHszJKP/W/bbhKnkKbDHxw1ew== X-Received: by 2002:a05:600c:3586:: with SMTP id p6mr644976wmq.48.1622490702584; Mon, 31 May 2021 12:51:42 -0700 (PDT) Received: from smtpclient.apple (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id q20sm812369wrf.45.2021.05.31.12.51.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 31 May 2021 12:51:42 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) Subject: Re: git: 5a20c351ea45 - main - [skip ci] add a CODEOWNERS file From: Jessica Clarke In-Reply-To: Date: Mon, 31 May 2021 20:51:41 +0100 Cc: Warner Losh , Ed Maste , src-committers , "" , dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <2A5E1D70-53BF-45EA-A668-6AF55294F10B@freebsd.org> References: <202105302249.14UMnbcl094541@gitrepo.freebsd.org> <0434E9D2-B0AA-4B5E-942A-A393A83DFFD1@freebsd.org> To: Alan Somers X-Mailer: Apple Mail (2.3654.100.0.2.22) X-Rspamd-Queue-Id: 4Fv5XJ0xwrz4pJp X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 May 2021 19:51:44 -0000 On 31 May 2021, at 20:50, Alan Somers wrote: >=20 > On Mon, May 31, 2021 at 1:39 PM Jessica Clarke = wrote: > On 31 May 2021, at 20:37, Warner Losh wrote: > >=20 > >=20 > >=20 > > On Mon, May 31, 2021 at 1:21 PM Jessica Clarke = wrote: > > On 31 May 2021, at 20:16, Warner Losh wrote: > > >=20 > > >=20 > > >=20 > > > On Mon, May 31, 2021, 1:11 PM Ed Maste wrote: > > > On Mon, 31 May 2021 at 11:51, Alan Somers = wrote: > > > > > > > >> > > > >> I think this file isn't the right place for (another copy of) = this > > > >> text; perhaps the CODEOWNERS file should just reference the = top-level > > > >> MAINTAINERS? > > > > > > > > Except that CODEOWNERS is in a format that tools know how to = parse. If anything, MAINTAINERS should be a symlink to CODEOWNERS. > > >=20 > > > At least the file's location and user IDs suggest that it is = specific > > > to GitHub; in any case I don't really care which one points to = which. > > > I hope we can agree though that we don't really want two different > > > files representing code ownership in different ways that both > > > independently refer to a third mechanism for recording code = ownership > > > that's external to the source tree? > > >=20 > > > It also works on gitlab, FWIW. The format is standard. Bummer we = can't generate it based on where it is published=E2=80=A6 > >=20 > > We could conceivably have a CODEOWNERS.master from which the others = can be generated via `make codeowners` whenever someone edits it. = Whether that=E2=80=99s worth the hassle of implementing though for a = file that shouldn=E2=80=99t regularly be changing is unclear. > >=20 > > Doing that's trivial... However, it would mean that the automatic = flagging that this file's presence gives wouldn't work... But then = again, there's no issues or pull requests at the gitlab mirror, so at = the moment it's a bit of a moot point. >=20 > A hypothetical .gitlab/CODEOWNERS would be checked in as a generated = file, if that was unclear. Otherwise I=E2=80=99m not sure I understand = your first point? >=20 > Jess >=20 > There's no need to generate anything. Both github and gitlab support = a CODEOWNERS file in the project's root. Let's just move it there. We = can delete the old MAINTAINERS, too, once all of its entries have been = converted. Not if people have different usernames between FreeBSD, GitHub and = GitLab? Or can it work off email addresses and we can rely on people = adding their @FreeBSD.org to their account? Though that still doesn=E2=80=99= t work for groups. Jess