From owner-cvs-all Fri Oct 18 12: 6:40 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 955CB37B401; Fri, 18 Oct 2002 12:06:38 -0700 (PDT) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1EC0F43EAF; Fri, 18 Oct 2002 12:06:38 -0700 (PDT) (envelope-from sam@errno.com) Received: from melange (melange.errno.com [66.127.85.82]) (authenticated bits=0) by ebb.errno.com (8.12.5/8.12.1) with ESMTP id g9IJ6N1H017797 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Fri, 18 Oct 2002 12:06:23 -0700 (PDT)?g (envelope-from sam@errno.com)œ X-Authentication-Warning: ebb.errno.com: Host melange.errno.com [66.127.85.82] claimed to be melange Message-ID: <2f2c01c276d9$73946100$52557f42@errno.com> From: "Sam Leffler" To: "Giorgos Keramidas" , "Robert Watson" Cc: "Kris Kennaway" , , References: <20021012222137.GA95508@xor.obsecurity.org> <20021018150821.GH30849@hades.hell.gr> Subject: Re: cvs commit: src/lib/libdisk disk.c Date: Fri, 18 Oct 2002 12:06:23 -0700 Organization: Errno Consulting MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4807.1700 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4807.1700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG I discovered this yesterday and phk commit'd a fix to add the \0. Sam ----- Original Message ----- From: "Giorgos Keramidas" To: "Robert Watson" Cc: "Kris Kennaway" ; ; Sent: Friday, October 18, 2002 8:08 AM Subject: Re: cvs commit: src/lib/libdisk disk.c > On 2002-10-12 18:23, Robert Watson wrote: > > On Sat, 12 Oct 2002, Kris Kennaway wrote: > > > (gdb) print disklist > > > $1 = 0x80d6130 "ad0", '' ... > > > > > > (the character between the '' is ascii 0xd0, the character malloc > > > debugging uses with the 'J' flag). > > > > > > I don't know why other people hadnt seen this. > > > > Perhaps in NO_GEOM, kern.disks has a NUL termination, and in GEOM it > > doesn't? Are you running with GEOM? > > Could very well be true. That would explain why I stumbled upon the > mdconfig -l bug that I fixed in my last commit there, right after > enabling GEOM. I don't remember having any problems with mdconfig > before turning on GEOM. The fix was similar there... and it also > depended on kern.disks data. > > Giorgos. > > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message