Date: Fri, 18 Oct 2002 12:06:23 -0700 From: "Sam Leffler" <sam@errno.com> To: "Giorgos Keramidas" <keramida@ceid.upatras.gr>, "Robert Watson" <rwatson@FreeBSD.org> Cc: "Kris Kennaway" <kris@obsecurity.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/lib/libdisk disk.c Message-ID: <2f2c01c276d9$73946100$52557f42@errno.com> References: <20021012222137.GA95508@xor.obsecurity.org> <Pine.NEB.3.96L.1021012182247.44458E-100000@fledge.watson.org> <20021018150821.GH30849@hades.hell.gr>
next in thread | previous in thread | raw e-mail | index | archive | help
I discovered this yesterday and phk commit'd a fix to add the \0.
Sam
----- Original Message -----
From: "Giorgos Keramidas" <keramida@ceid.upatras.gr>
To: "Robert Watson" <rwatson@FreeBSD.org>
Cc: "Kris Kennaway" <kris@obsecurity.org>; <cvs-committers@FreeBSD.org>;
<cvs-all@FreeBSD.org>
Sent: Friday, October 18, 2002 8:08 AM
Subject: Re: cvs commit: src/lib/libdisk disk.c
> On 2002-10-12 18:23, Robert Watson <rwatson@FreeBSD.ORG> wrote:
> > On Sat, 12 Oct 2002, Kris Kennaway wrote:
> > > (gdb) print disklist
> > > $1 = 0x80d6130 "ad0", '' <repeats 197 times>...
> > >
> > > (the character between the '' is ascii 0xd0, the character malloc
> > > debugging uses with the 'J' flag).
> > >
> > > I don't know why other people hadnt seen this.
> >
> > Perhaps in NO_GEOM, kern.disks has a NUL termination, and in GEOM it
> > doesn't? Are you running with GEOM?
>
> Could very well be true. That would explain why I stumbled upon the
> mdconfig -l bug that I fixed in my last commit there, right after
> enabling GEOM. I don't remember having any problems with mdconfig
> before turning on GEOM. The fix was similar there... and it also
> depended on kern.disks data.
>
> Giorgos.
>
>
>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2f2c01c276d9$73946100$52557f42>