From owner-svn-ports-head@FreeBSD.ORG Fri Sep 20 08:32:48 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 2A48480A for ; Fri, 20 Sep 2013 08:32:48 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from mail-lb0-f175.google.com (mail-lb0-f175.google.com [209.85.217.175]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9058826F5 for ; Fri, 20 Sep 2013 08:32:47 +0000 (UTC) Received: by mail-lb0-f175.google.com with SMTP id y6so336658lbh.20 for ; Fri, 20 Sep 2013 01:32:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=O2BDyT2T3BYlsFN4gj1XHDjaT5f5LgfLI+5rIbXzzAE=; b=JhxUSf2guWwD6WOG2wMnqxJRDD/p7rXikuaETayFX2ICruBuXA9kzT7q3nRMWhw9wq gssXFSks1u/H1iec7SqO3aKSQysCqQF9WI4G9+i2qEe3KL0HZhFv1bl34X71yxOmrkWN sfnTOHpoSSHiquC5/tu0HrBPP7334T8DyTWEO5S0nCoS13Pex/8SqYzXNjvcpPo+7W1Y dXrfIfjDCsQvco7auZ08VRHnlVWnSRE4pNjL1twBO51yNTuWOo5w7ayWwKSl/chiUwnL /xLK3n62OFvihACR3l10j/h80CWwG1U5rev/Y+5x9S0Z6TANbFCRL0DpdOsG/bCkdFfp hmaw== X-Gm-Message-State: ALoCoQl78XPowdchPELaCgwwDKD4lRB+Pv3kR/aNwMYoElX9YCokvY0WJWn9jGZ340VK6CW0fcT7 X-Received: by 10.152.8.51 with SMTP id o19mr409330laa.42.1379665965157; Fri, 20 Sep 2013 01:32:45 -0700 (PDT) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 10.112.91.9 with HTTP; Fri, 20 Sep 2013 01:32:25 -0700 (PDT) In-Reply-To: <201309190805.r8J855cW009011@svn.freebsd.org> References: <201309190805.r8J855cW009011@svn.freebsd.org> From: Sunpoet Po-Chuan Hsieh Date: Fri, 20 Sep 2013 16:32:25 +0800 X-Google-Sender-Auth: oTR4CXvhKC0qr-hl65OMavcGafU Message-ID: Subject: Re: svn commit: r327601 - head/Mk To: Baptiste Daroussin Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Sep 2013 08:32:48 -0000 Hi Bapt, May I suggest to change hard-coded sleep time to a settable variable defaults to 10? It would save time while checking multiple ports with terminal outputs redirected to a log file. Thanks. Regards, sunpoet On Thu, Sep 19, 2013 at 4:05 PM, Baptiste Daroussin wrote: > Author: bapt > Date: Thu Sep 19 08:05:05 2013 > New Revision: 327601 > URL: http://svnweb.freebsd.org/changeset/ports/327601 > > Log: > Move the target for sanity checking to the end of bsd.port.mk so that > WARNING and DEV_* can be defined anywhere > While here, change sleep time from 5 to 10 so that users have time to > read it [1] > > Suggested by: many [1] > > Modified: > head/Mk/bsd.port.mk > head/Mk/bsd.sanity.mk > > Modified: head/Mk/bsd.port.mk > > ============================================================================== > --- head/Mk/bsd.port.mk Thu Sep 19 07:50:29 2013 (r327600) > +++ head/Mk/bsd.port.mk Thu Sep 19 08:05:05 2013 (r327601) > @@ -6491,6 +6491,43 @@ install-license: > @${DO_NADA} > .endif > > +.if defined(WARNING) > +show-warnings: > + @${ECHO_MSG} "/!\\ WARNING /!\\" > +.for m in ${WARNING} > + @${ECHO_MSG} "${m}" > +.endfor > + @${ECHO_MSG} > + @sleep 10 > + > +check-makefile:: show-warnings > +.endif > + > +.if defined(DEVELOPER) > +.if defined(DEV_WARNING) > +show-dev-warnings: > + @${ECHO_MSG} "/!\\ ${PKGNAME}: Makefile warnings, please consider > fixing /!\\" > + @${ECHO_MSG} > +.for m in ${DEV_WARNING} > + @${ECHO_MSG} "${m}" > +.endfor > + @${ECHO_MSG} > + @sleep 10 > +check-makefile:: show-dev-warnings > +.endif > + > +.if defined(DEV_ERROR) > +show-dev-errors: > + @${ECHO_MSG} "/!\\ ${PKGNAME}: Makefile errors /!\\" > + @${ECHO_MSG} > +.for m in ${DEV_WARNING} > + @${ECHO_MSG} "${m}" > +.endfor > + @${ECHO_MSG} > + @${FALSE} > +check-makefile:: show-dev-errors > +.endif > +.endif #DVELOPER > .endif > # End of post-makefile section. > > > Modified: head/Mk/bsd.sanity.mk > > ============================================================================== > --- head/Mk/bsd.sanity.mk Thu Sep 19 07:50:29 2013 (r327600) > +++ head/Mk/bsd.sanity.mk Thu Sep 19 08:05:05 2013 (r327601) > @@ -91,41 +91,6 @@ DEV_WARNING+= "USE_GNOME=ltverhack is no > DEV_WARNING+= "Please use the new format for LIB_DEPENDS, see handbook > for details" > .endif > > -.if defined(WARNING) > -show-warnings: > -.for m in ${WARNING} > - @${ECHO_MSG} "${m}" > -.endfor > - @sleep 5 > - > -check-makefile:: show-warnings > -.endif > - > .if defined(_PREMKINCLUDED) > DEV_ERROR+= "you cannot include bsd.port[.pre].mk twice" > .endif > - > -.if defined(DEVELOPER) > -.if defined(DEV_WARNING) > -show-dev-warnings: > - @${ECHO_MSG} "/!\\ ${PKGNAME}: Makefile warnings, please consider > fixing /!\\" > - @${ECHO_MSG} > -.for m in ${DEV_WARNING} > - @${ECHO_MSG} "${m}" > -.endfor > - @${ECHO_MSG} > - @sleep 5 > -check-makefile:: show-dev-warnings > -.endif > - > -.if defined(DEV_ERROR) > -show-dev-errors: > - @${ECHO_MSG} "/!\\ ${PKGNAME}: Makefile errors /!\\" > - @${ECHO_MSG} > -.for m in ${DEV_WARNING} > - @${ECHO_MSG} "${m}" > -.endfor > - @${FALSE} > -check-makefile:: show-dev-errors > -.endif > -.endif >