Date: Sat, 02 Jul 2016 15:24:52 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 209742] devel/godot: Improve port (v2.0.3); add devel/godot-tools port Message-ID: <bug-209742-13-IKcUB9G8Mv@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-209742-13@https.bugs.freebsd.org/bugzilla/> References: <bug-209742-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209742 --- Comment #44 from Shane <FreeBSD@ShaneWare.Biz> --- (In reply to lightside from comment #42) The proc filesystem is optional on FreeBSD, so we can't rely on it being th= ere. If it is there then the /proc path could be used, which would mean checking= if it is there and if it isn't, then use sysctl, as the sysctl call has to be there, there is no point of the extra check of whether /proc exists. http://freebsd.1045724.n5.nabble.com/Why-is-procfs-deprecated-in-favor-of-p= rocstat-td4028960.html https://www.freebsd.org/doc/en/articles/linux-users/procfs.html The libexecinfo/backtrace.c example sets the path, if KERN_PROC_PATHNAME ex= ists then it overrides the earlier /proc path definition by calling sysctl. The ptrace example is expected to be asking for paths to other executables = with many possible outcomes, any situation could arise from that, no permission, process crashes before the path was returned.... so extra checks can be expected. (In reply to lightside from comment #43) I don't think my earlier change to OS_Unix::execute() should be added back.= It was short sighted of me to do that change when I first got godot running, at that time I didn't see it being used outside of initially starting godot. W= hile I think using execvp() is useful, the use of getprogname() would have to be removed. As this change would make FreeBSD act differently to other platfor= ms I don't think leaving it there is a good idea. Let's keep the FreeBSD specific code limited to OS_Unix::get_executable_path() --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-209742-13-IKcUB9G8Mv>