From owner-svn-src-head@freebsd.org Mon Jul 31 03:25:22 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B62B5DC8696; Mon, 31 Jul 2017 03:25:22 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "anubis.delphij.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9AAD0657A4; Mon, 31 Jul 2017 03:25:22 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from Xins-MBP.ut.rhv.delphij.net (unknown [IPv6:2601:646:8882:37a:dd8a:e75a:9211:e42a]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by anubis.delphij.net (Postfix) with ESMTPSA id 21F5F16B47; Sun, 30 Jul 2017 20:25:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=delphij.net; s=anubis; t=1501471522; x=1501485922; bh=nVWrdevmntQTfrx6lGfpHGjvTDTQ9VSns0VuPnCvnKc=; h=Cc:Subject:To:References:From:Date:In-Reply-To; b=5ID7QVHtb6qKqIBb2fxC2pw6UY7rgRn85dP4hjlX80g0cwPgzLLipqcqjQhqvJyh3 5rg/gKHr6YQV35biQ5E5ENXXO7yEVwY9Cu+wrgnUBxmgVSPw++5nX0qJm6VlPf3uDq e4UqfDfO56psX0tCC9jubkRWmADjAG1/m5arLh2o= Cc: d@delphij.net Subject: Re: svn commit: r321605 - head/contrib/ipfilter To: Cy Schubert , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201707270626.v6R6QFpx016943@repo.freebsd.org> From: Xin Li Message-ID: <59e80a44-d9de-5081-9eda-f068188b843f@delphij.net> Date: Sun, 30 Jul 2017 20:25:19 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <201707270626.v6R6QFpx016943@repo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qkHf0G7WFcstcsFV7l4rWHvsuGQw2vRUe" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2017 03:25:22 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qkHf0G7WFcstcsFV7l4rWHvsuGQw2vRUe Content-Type: multipart/mixed; boundary="Jr1WPDWc9v4DdGMW1MpMm9tsIXBjADiqo"; protected-headers="v1" From: Xin Li To: Cy Schubert , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Cc: d@delphij.net Message-ID: <59e80a44-d9de-5081-9eda-f068188b843f@delphij.net> Subject: Re: svn commit: r321605 - head/contrib/ipfilter References: <201707270626.v6R6QFpx016943@repo.freebsd.org> In-Reply-To: <201707270626.v6R6QFpx016943@repo.freebsd.org> --Jr1WPDWc9v4DdGMW1MpMm9tsIXBjADiqo Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 7/26/17 23:26, Cy Schubert wrote: > Author: cy > Date: Thu Jul 27 06:26:15 2017 > New Revision: 321605 > URL: https://svnweb.freebsd.org/changeset/base/321605 >=20 > Log: > As in r315225, discard 3072 bytes of RC4 bytestream instead of 1024. > =20 > PR: 217920 > Submitted by: codarren@hackers.mu > Reviewed by: emaste, cem > Approved by: so (implicit, in r315225) Why ipfilter is using its own pseudo random number generator? Please remove them altogether and use the system PRNG instead. Cheers, --Jr1WPDWc9v4DdGMW1MpMm9tsIXBjADiqo-- --qkHf0G7WFcstcsFV7l4rWHvsuGQw2vRUe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJZfqMiAAoJEJW2GBstM+nsjK4P/161Peu4RfRmB8f0r+7CdWlG Dxcbrtr5pf+4TeKtPPIOv9QobeVPCxcCN2Ec3Pb/+LBjy3f/XrJYzzS0yAWz6gkr 2TB67Kuvp9wTCLZcyxu8fB10L4lT3cNOrwQ2Xr8FjJdJJXrPp6Dol3P5TGHdbpD4 K0F3wOw7ZNjWH6RmhKJXEFSkzX4VFtKONMItZlCtgqubObvWEbpUvsoC95hfs8er IIAlPNh48LxtTrEpyRDu2hqd/XTx52Rpcut1jfRo5rvaKAfZl2YGalnYX0NllFjo P1wpmI2ZJSMxfKaopeFLjwac9ri1IKicJaahGryU1r82YdMDrcDmoMJ7Bu8JsZoC NBzVc9mFmiv11MdyIUUbPsnVWXzhaDjkXedPuRSjWriODk2JzQf5t3NIS1kEyU8I lsCU16CWndH4+l7Kdg3G5BGFGCpM1/ubYobiJObUjrahwE2TGNrytu49ESm5eUdy LVbOwoq1NWg+M6nGLnPyZUEz0emorXbmebVzGFyl7NX6cIh31yNXoupvR+O9Gm/L jQmD9Mhfnb5Vi/N2KEl2Io4udVMOX84/vqALWN+09YgretG3MY4V1QywBbA8ZZJk 8bpEVsTrBJNFpZq8rF08t5O7jYs9AfzZ5qWEehBIus1AhpyVz/kSj+E9Bc7FbYRG lgFwudjhcxnLZqk+vBXh =B0Ry -----END PGP SIGNATURE----- --qkHf0G7WFcstcsFV7l4rWHvsuGQw2vRUe--