From owner-cvs-all  Sat May 11 10: 5:14 2002
Delivered-To: cvs-all@freebsd.org
Received: from Awfulhak.org (gw.Awfulhak.org [217.204.245.18])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8DBA237B403; Sat, 11 May 2002 10:05:08 -0700 (PDT)
Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [IPv6:fec0::1:12])
	by Awfulhak.org (8.12.3/8.12.3) with ESMTP id g4BH56fK071706;
	Sat, 11 May 2002 18:05:06 +0100 (BST)
	(envelope-from brian@Awfulhak.org)
Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1])
	by hak.lan.Awfulhak.org (8.12.3/8.12.3) with ESMTP id g4BH51nA052445;
	Sat, 11 May 2002 18:05:01 +0100 (BST)
	(envelope-from brian@hak.lan.Awfulhak.org)
Message-Id: <200205111705.g4BH51nA052445@hak.lan.Awfulhak.org>
X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4
To: Mike Barcroft <mike@FreeBSD.org>
Cc: Brian Somers <brian@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org, brian@freebsd-services.com
Subject: Re: cvs commit: src/usr.sbin/ppp mppe.c 
In-Reply-To: Message from Mike Barcroft <mike@FreeBSD.org> 
   of "Sat, 11 May 2002 11:26:14 EDT." <20020511112614.A59782@espresso.q9media.com> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Sat, 11 May 2002 18:05:01 +0100
From: Brian Somers <brian@Awfulhak.org>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

> Brian Somers <brian@FreeBSD.org> writes:
> > brian       2002/05/11 03:54:45 PDT
> > 
> >   Modified files:
> >     usr.sbin/ppp         mppe.c 
> >   Log:
> >   #include netinet/in.h when !__FreeBSD__ to silence some warnings from
> >   the inclusion of arpa/inet.h
> >   
> >   Revision  Changes    Path
> >   1.18      +3 -0      src/usr.sbin/ppp/mppe.c
> 
> I think you could just remove the <arpa/inet.h> include and use
> <netinet/in.h> unconditionally.

Indeed (although byteorder(3) says arpa/inet.h is required).

In fact, {Net,Open}BSD don't need netinet/in.h either.

> Best regards,
> Mike Barcroft

-- 
Brian <brian@freebsd-services.com>                <brian@Awfulhak.org>
      http://www.freebsd-services.com/        <brian@[uk.]FreeBSD.org>
Don't _EVER_ lose your sense of humour !      <brian@[uk.]OpenBSD.org>



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message