From owner-cvs-all@FreeBSD.ORG  Fri Feb 13 14:31:20 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DDE7816A4CE
	for <cvs-all@FreeBSD.org>; Fri, 13 Feb 2004 14:31:20 -0800 (PST)
Received: from smtp.mho.com (smtp.mho.net [64.58.4.5])
	by mx1.FreeBSD.org (Postfix) with SMTP id A68F143D41
	for <cvs-all@FreeBSD.org>; Fri, 13 Feb 2004 14:31:20 -0800 (PST)
	(envelope-from scottl@freebsd.org)
Received: (qmail 85862 invoked by uid 1002); 13 Feb 2004 22:31:18 -0000
Received: from unknown (HELO ?10.4.1.17?) (64.58.1.252)
  by smtp.mho.net with SMTP; 13 Feb 2004 22:31:18 -0000
Date: Fri, 13 Feb 2004 15:31:49 -0700 (MST)
From: Scott Long <scottl@freebsd.org>
X-X-Sender: scottl@pooker.samsco.home
To: Julian Elischer <julian@FreeBSD.org>
In-Reply-To: <200402132136.i1DLaYii065621@repoman.freebsd.org>
Message-ID: <20040213152836.U25703@pooker.samsco.home>
References: <200402132136.i1DLaYii065621@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/bfe if_bfe.c if_bfereg.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Feb 2004 22:31:21 -0000

On Fri, 13 Feb 2004, Julian Elischer wrote:
> julian      2004/02/13 13:36:34 PST
>
>   FreeBSD src repository
>
>   Modified files:        (Branch: RELENG_4)
>     sys/dev/bfe          if_bfe.c if_bfereg.h
>   Log:
>   Upgrade to the version of the MFC by  Edwin Groothuis.
>   This seems to work but I have heard of hangs...
>
>   Revision  Changes    Path
>   1.4.4.3   +101 -91   src/sys/dev/bfe/if_bfe.c
>   1.1.4.3   +12 -0     src/sys/dev/bfe/if_bfereg.h
>
>

Julian,

Are you willing to stand by this commit?  Your comment implies that you
don't know if it works or not.  If so, then RELENG_4 is certainly not the
place for this.  Mr. Groothuis might have done a fine job with this, but
unless you as a committer and senior member of this project are willing
to actually review, test, and validate it, then it needs to be backed out
and revisited at a later date.

Scott