From owner-svn-src-head@freebsd.org Sat Sep 3 15:47:13 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 58D4FBCEB9F for ; Sat, 3 Sep 2016 15:47:13 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-wm0-x235.google.com (mail-wm0-x235.google.com [IPv6:2a00:1450:400c:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E8CA4F13 for ; Sat, 3 Sep 2016 15:47:12 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by mail-wm0-x235.google.com with SMTP id v143so17116391wmv.0 for ; Sat, 03 Sep 2016 08:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+HUBMQqm03+L9Xj/IIojdokRjx7hD6AxuJlpkXKn/rk=; b=a/IKIMbaEZULYvLtd8W5MS3fpK0qJVI7oijt/IwJ58H6Q+rdrpWxnUf30qXBdxk27T C1qjh1eZKYtorAJX2VkGsid0UwpBQZgeupzDeijD6+z14NjVKMaVydHqjgBs54B+zacS rJdtkBNuvZH5h1eiIkaRZ9YuyPOkV9+orjB8XmmNluitw67FM6cfa+9+PdFjyikGgLp+ iN80ZFj2F/Vk33dOVLWKQmk5WII/xG7gIx53IiguLzw7lq35kpUT+iVpRmKPq1URvx8I BOYASIdjypBtcqwlzIGCe/WtvncPgZAmF/2aB4UNHUaL2JfspQ0V9fihUzz/qvv6VS8H Jjeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+HUBMQqm03+L9Xj/IIojdokRjx7hD6AxuJlpkXKn/rk=; b=I7/BIV5k9zVGAxnmoGTNNZTuSO6hDKvttN8oyGJuJ7m3EdIlWfVVyrE8/0CUw02uJi 9kq+BapPZoI++0LXboSIYgieb+Z9TofA1TBCkOlDR7A5z4Y3XAXSnF7EBy9Vc72mwyIt eU0kjiy6hKdEqCSOcruY6RxJyXQkoPdpRdwZVhbVxXWIUcQUjtFnt9VeUuKIbl0GdIhN 708SAlP+PvFtVeY0uH+/K+HzDJYrHzZs0o9wGgXGQgIEe/ot55/xbxku7WLVPqtazl61 DE/ww16JkggES8jR0X2xPLS00ymqqAHennghIyOF7p7H2/1FzXaSe8Qtq9Ho+YM0wSKl mV/Q== X-Gm-Message-State: AE9vXwNFZm6UZQ7ebqT8q0EaOANcESbcrCDOOkV54mjUzwmNWbC4rYRBepQ963tH2vnC5KbECRBUmbIcyvOLfKRp X-Received: by 10.28.94.85 with SMTP id s82mr7757622wmb.24.1472917631484; Sat, 03 Sep 2016 08:47:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.236.231 with HTTP; Sat, 3 Sep 2016 08:47:11 -0700 (PDT) In-Reply-To: <201609031528.u83FS91u017461@repo.freebsd.org> References: <201609031528.u83FS91u017461@repo.freebsd.org> From: Oliver Pinter Date: Sat, 3 Sep 2016 17:47:11 +0200 Message-ID: Subject: Re: svn commit: r305354 - head/sys/arm/allwinner To: Jared McNeill Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Sep 2016 15:47:13 -0000 Hi! On 9/3/16, Jared McNeill wrote: > Author: jmcneill > Date: Sat Sep 3 15:28:09 2016 > New Revision: 305354 > URL: https://svnweb.freebsd.org/changeset/base/305354 > > Log: > Use the root key in the Security ID EFUSE (when valid) to generate a > MAC address instead of creating a random one each boot. Could you please describe a little more about this root key? What is it? What's the main purpose? Is is a crypto root key? > > Modified: > head/sys/arm/allwinner/if_awg.c > > Modified: head/sys/arm/allwinner/if_awg.c > ============================================================================== > --- head/sys/arm/allwinner/if_awg.c Sat Sep 3 15:26:28 2016 (r305353) > +++ head/sys/arm/allwinner/if_awg.c Sat Sep 3 15:28:09 2016 (r305354) > @@ -62,6 +62,7 @@ __FBSDID("$FreeBSD$"); > #include > > #include > +#include > #include > #include > > @@ -1277,6 +1278,7 @@ awg_get_eaddr(device_t dev, uint8_t *ead > { > struct awg_softc *sc; > uint32_t maclo, machi, rnd; > + u_char rootkey[16]; > > sc = device_get_softc(dev); > > @@ -1285,9 +1287,19 @@ awg_get_eaddr(device_t dev, uint8_t *ead > > if (maclo == 0xffffffff && machi == 0xffff) { > /* MAC address in hardware is invalid, create one */ > - rnd = arc4random(); > - maclo = 0x00f2 | (rnd & 0xffff0000); > - machi = rnd & 0xffff; > + if (aw_sid_get_rootkey(rootkey) == 0 && > + (rootkey[3] | rootkey[12] | rootkey[13] | rootkey[14] | > + rootkey[15]) != 0) { > + /* MAC address is derived from the root key in SID */ > + maclo = (rootkey[13] << 24) | (rootkey[12] << 16) | > + (rootkey[3] << 8) | 0x02; > + machi = (rootkey[15] << 8) | rootkey[14]; > + } else { > + /* Create one */ > + rnd = arc4random(); > + maclo = 0x00f2 | (rnd & 0xffff0000); > + machi = rnd & 0xffff; > + } > } > > eaddr[0] = maclo & 0xff; > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >