From owner-svn-ports-all@FreeBSD.ORG  Thu Jan 15 10:27:16 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 850628E7;
 Thu, 15 Jan 2015 10:27:16 +0000 (UTC)
Received: from fep16.mx.upcmail.net (fep16.mx.upcmail.net [62.179.121.36])
 by mx1.freebsd.org (Postfix) with ESMTP id 6E824B6C;
 Thu, 15 Jan 2015 10:27:14 +0000 (UTC)
Received: from edge03.upcmail.net ([192.168.13.238]) by viefep16-int.chello.at
 (InterMail vM.8.01.05.13 201-2260-151-135-20130320) with ESMTP
 id <20150115102707.TCSN26000.viefep16-int.chello.at@edge03.upcmail.net>;
 Thu, 15 Jan 2015 11:27:07 +0100
Received: from [192.168.0.23] ([178.84.134.112])
 by edge03.upcmail.net with edge
 id gAT21p01x2Rg3Ey01AT35E; Thu, 15 Jan 2015 11:27:03 +0100
X-SourceIP: 178.84.134.112
Message-ID: <54B795F4.2070308@rainbow-runner.nl>
Date: Thu, 15 Jan 2015 11:27:00 +0100
From: Koop Mast <kwm@rainbow-runner.nl>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, 
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r377068 - in head/devel: . gnu-efi gnu-efi/files
References: <201501150955.t0F9tvlO075446@svn.freebsd.org>
 <54B78FEE.4020705@rainbow-runner.nl> <20150115101118.GA3203@pc5.home>
In-Reply-To: <20150115101118.GA3203@pc5.home>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Jan 2015 10:27:16 -0000

On 15-1-2015 11:11, Edward Tomasz Napierala wrote:
> On 0115T1101, Koop Mast wrote:
>> On 15-1-2015 10:55, Edward Tomasz Napierala wrote:
>>> Author: trasz
>>> Date: Thu Jan 15 09:55:56 2015
>>> New Revision: 377068
>>> URL: https://svnweb.freebsd.org/changeset/ports/377068
>>> QAT: https://qat.redports.org/buildarchive/r377068/
>>>
>>> Log:
>>>    New port: devel/gnu-efi
> [..]
>
>>> + # Compilation tools
>>> +-HOSTCC       := $(prefix)gcc
>>> +-CC           := $(prefix)$(CROSS_COMPILE)gcc
>>> ++HOSTCC       := $(prefix)gcc48
>>> ++CC           := $(prefix)$(CROSS_COMPILE)gcc48
>>> + AS           := $(prefix)$(CROSS_COMPILE)as
>>> + LD           := $(prefix)$(CROSS_COMPILE)ld
>>> + AR           := $(prefix)$(CROSS_COMPILE)ar
>>>
>> This doesn't look right. In the Makefile your set USE_GCC=4.8+, so
>> gcc 4.9 could be used. So these lines need to be adapted to that into
>> account.
> Hm, you're right.  What's the suggested way - force 4.8, or somehow
> make the diff above adapt to GCC version?
>
>

What about this patch? [1]:
USE_GCC will set ${CC} for us, we just use sed to add it to 
Make.defaults. Bonus points is that when lang/gcc is bumped to a newer 
version we don't have to fix the makefile anymore.
I also think USE_GCC=yes can be used since lang/gcc is 4.8, which is the 
default gcc port.

-Koop

[1] https://people.freebsd.org/~kwm/gnu-efi-gcc.diff