Date: Sun, 7 Oct 2012 14:33:02 +0300 From: Alex Kozlov <ak@FreeBSD.org> To: Boris Samorodov <bsam@passap.ru> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r305403 - head/graphics/eos-movrec Message-ID: <20121007113302.GA75223@ravenloft.kiev.ua> In-Reply-To: <50715F3E.8020201@passap.ru> References: <201210062105.q96L5Dth040796@svn.freebsd.org> <50713F44.5010603@passap.ru> <20121007094519.GA23625@ravenloft.kiev.ua> <50715F3E.8020201@passap.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Oct 07, 2012 at 02:53:50PM +0400, Boris Samorodov wrote: > 07.10.2012 13:45, Alex Kozlov пишет: > > On Sun, Oct 07, 2012 at 12:37:24PM +0400, Boris Samorodov wrote: > >> Hello Alex, > >> > >>> Log: > >>> - Convert Makefile headers to new style > >>> - Add DESKTOP_ENTRIES > >>> - Pass maintainership to nemysis <nemysis@gmx.ch> > >> As for me this is too simplified commit log. May be added: > >> > >> - Use bzip2 instead of zip tarball (greatly reduses the size) > >> - Remove duplicate PORTREVISION > >> - Remove the indefinite article from COMMENT > >> - Remove shlib version from the dependency > >> - convert and install icon *.png from *.ico > > Apologies, I forgot to update message file. > There is absolutely no need to apologize. We are all learning something > new everyday. ;-) You're too kind. > >>> Modified: head/graphics/eos-movrec/Makefile > >>> ============================================================================== > >>> --- head/graphics/eos-movrec/Makefile Sat Oct 6 20:50:12 2012 (r305402) > >>> +++ head/graphics/eos-movrec/Makefile Sat Oct 6 21:05:12 2012 (r305403) > >>> @@ -1,34 +1,42 @@ > >>> -# New ports collection makefile for: EOS camera movie record > >>> -# Date created: 15 Aug 2011 > >>> -# Whom: Alexey Dokuchaev <danfe@FreeBSD.org> > >>> -# > >>> # $FreeBSD$ > >>> -# > >>> +# Created by: Alexey Dokuchaev <danfe@FreeBSD.org> > >> Imho this line should be the first one. > > At the moment there are three or four variants of Makefile headers in the tree. > > I try to be as close as possible to the official version: > > http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-samplem.html > OK, here is the official announcement about new header style: > http://goo.gl/r31Bb So, the porters handbook and announcement contradict each other. This should be fixed. I will implement all your and makc@ suggestions except for headers order. For them I will wait until documentation would be harmonised. -- Alex
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121007113302.GA75223>