Date: Mon, 12 Apr 2021 12:50:01 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 254964] Integer overflow in ffs_setextattr() could lead to a kernel heap overflow Message-ID: <bug-254964-227-DkDudRk29S@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-254964-227@https.bugs.freebsd.org/bugzilla/> References: <bug-254964-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D254964 Mark Johnston <markj@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |markj@FreeBSD.org --- Comment #1 from Mark Johnston <markj@FreeBSD.org> --- The attribute name length is checked by callers of the VOP, or is not user-controlled to begin with. Callers of extattr_set_vp(), for example, w= ill provide a string of length at most EXTATTR_MAXNAMELEN =3D=3D NAME_MAX. We = should perhaps assert this limit in ffs_setextattr(). ip->i_ea_len is not directly user-controlled, it is the size of the extattrs for the inode represented by ip. The space reserved for extattrs is limite= d to two blocks and ffs_setextattr() checks this. I may well be missing something - do you have a test case to demonstrate the problem? --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-254964-227-DkDudRk29S>