Date: Sat, 12 Oct 2013 08:30:01 GMT From: Scot Hetzel <swhetzel@gmail.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/182283: audio/akode*: Fix build with Clang and newer versions of GCC Message-ID: <201310120830.r9C8U1Lg060438@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/182283; it has been noted by GNATS.
From: Scot Hetzel <swhetzel@gmail.com>
To: bug-followup@freebsd.org
Cc:
Subject: Re: ports/182283: audio/akode*: Fix build with Clang and newer
versions of GCC
Date: Sat, 12 Oct 2013 03:28:48 -0500
On Thu, Sep 26, 2013 at 1:53 AM, Scot Hetzel <swhetzel@gmail.com> wrote:
> Here is the final patch:
>
> - Fix build with clang by avoiding shadowing in template definitions
> (Obtained from NetBSD's pkgsrc)
> - Add missing includes for <cstring>, <cstdlib> to allow akode to
> build with newer versions of GCC.
> - Fix OPTIONS_DEFAULT as it had the XIPH option misspelled
> - Use a central patch directory for all akode* ports
> (PATCHDIR=${MASTERSITE}/../akode/files)
> - Simplify the akode-plugins-* ports by removing the
> do-{build,install} targets from the ports Makefile
> -- The do-{build,install} targets did the same thing as the ones in
> the bsd.port.mk
> -- This should allow the ports to use the new staging area (NO_STAGE
> could be removed from the Makefiles)
> - fix several portlint errors in the ports
>
Could some one apply this patch to the akode ports as it resolves
several build errors detected by pkg-fallout with gcc46 and clang:
http://beefy1.isc.freebsd.org/bulk/head-i386-default/2013-10-10_05h56m46s/logs/akode-plugins-ffmpeg-2.0.2_4,1.log
http://beefy1.isc.freebsd.org/bulk/head-i386-default/2013-10-10_05h56m46s/logs/akode-plugins-jack-2.0.2,1.log
http://beefy1.isc.freebsd.org/bulk/head-i386-default/2013-10-10_05h56m46s/logs/akode-plugins-mpc-2.0.2,1.log
http://beefy1.isc.freebsd.org/bulk/head-i386-default/2013-10-10_05h56m46s/logs/akode-plugins-mpeg-2.0.2,1.log
http://beefy1.isc.freebsd.org/bulk/head-i386-default/2013-10-10_05h56m46s/logs/akode-plugins-oss-2.0.2,1.log
http://beefy1.isc.freebsd.org/bulk/head-i386-default/2013-10-10_05h56m46s/logs/akode-plugins-pulseaudio-2.0.2_5.log
http://beefy1.isc.freebsd.org/bulk/head-i386-default/2013-10-10_05h56m46s/logs/akode-plugins-resampler-2.0.2,1.log
http://beefy1.isc.freebsd.org/bulk/head-i386-default/2013-10-10_05h56m46s/logs/akode-plugins-xiph-2.0.2_5,1.log
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201310120830.r9C8U1Lg060438>