From owner-svn-ports-head@freebsd.org Fri Jul 7 12:01:52 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B90E8DA1A40; Fri, 7 Jul 2017 12:01:52 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9BB9B77818; Fri, 7 Jul 2017 12:01:52 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id C711D1213D; Fri, 7 Jul 2017 12:01:51 +0000 (UTC) Date: Fri, 7 Jul 2017 12:01:51 +0000 From: Alexey Dokuchaev To: Richard Gallamore Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r445123 - in head/net-mgmt/ccnet-client: . files Message-ID: <20170707120151.GA57983@FreeBSD.org> References: <201707060221.v662LNM1037673@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201707060221.v662LNM1037673@repo.freebsd.org> User-Agent: Mutt/1.8.2 (2017-04-18) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jul 2017 12:01:52 -0000 On Thu, Jul 06, 2017 at 02:21:23AM +0000, Richard Gallamore wrote: > New Revision: 445123 > URL: https://svnweb.freebsd.org/changeset/ports/445123 > > Log: > * Add patch to fix build for libressl > * Removed --enable-ldap, not a valid configure arg > > [...] > @@ -21,19 +22,17 @@ LIB_DEPENDS= libsearpc.so:devel/libsearpc \ > > CONFLICTS= ccnet-server-[0-9]* > > -USE_GITHUB= yes > -GH_ACCOUNT= haiwen > -GH_PROJECT= ccnet > - > USES= autoreconf gettext libtool localbase pathfix pkgconfig \ > python:-2.7 ssl > USE_GNOME= glib20 > USE_LDCONFIG= yes > USE_OPENLDAP= yes > +USE_GITHUB= yes > +GH_ACCOUNT= haiwen > +GH_PROJECT= ccnet Please try to avoid these gratuitous changes. GitHub-related knobs are often grouped together and put closer to the top because they are more related to obtaining the distfile (think MASTER_SITES) rather than the configuring/building/etc. steps of software itself. In any case, this move should've been reflected in the commit log with proper explanation. ./danfe