From owner-svn-src-all@freebsd.org Tue Oct 6 21:23:09 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 365949B6C64; Tue, 6 Oct 2015 21:23:09 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 11B4313A2; Tue, 6 Oct 2015 21:23:09 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 8BDFFB915; Tue, 6 Oct 2015 17:23:07 -0400 (EDT) From: John Baldwin To: Garrett Cooper Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r288907 - head/bin/ls/tests Date: Tue, 06 Oct 2015 11:26:36 -0700 Message-ID: <2474554.zI8qz6W2Yp@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-PRERELEASE; KDE/4.14.3; amd64; ; ) In-Reply-To: <201510060100.t9610CXc077196@repo.freebsd.org> References: <201510060100.t9610CXc077196@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 06 Oct 2015 17:23:07 -0400 (EDT) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 21:23:09 -0000 On Tuesday, October 06, 2015 01:00:12 AM Garrett Cooper wrote: > Author: ngie > Date: Tue Oct 6 01:00:12 2015 > New Revision: 288907 > URL: https://svnweb.freebsd.org/changeset/base/288907 > > Log: > Call sync consistently using atf_check > > Remove superfluous sync's You should not need to call sync() to see the results of earlier namespace changes (file create, rename, delete, etc.), even for NFS when looking on the same client that made the namespace change. Are you doing this to force mtime updates? You should not need sync() for that on UFS (ufs_getattr() forces any pending lazy timestamp updates). You would for NFS (not sure about ZFS). Whatever the reason for the syncs, I think it warrants a comment. -- John Baldwin