Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 9 Jul 2015 20:52:07 +0200
From:      John Marino <unicomp@marino.st>
To:        Tijl Coosemans <tijl@FreeBSD.org>, Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r391655 - head/databases/rocksdb
Message-ID:  <559EC2D7.5070004@marino.st>
In-Reply-To: <20150709204758.0d63e354@kalimero.tijl.coosemans.org>
References:  <201507091548.t69FmxqL020735@repo.freebsd.org> <20150709204758.0d63e354@kalimero.tijl.coosemans.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 7/9/2015 8:47 PM, Tijl Coosemans wrote:
> On Thu, 9 Jul 2015 15:48:59 +0000 (UTC) Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> wrote:
>> Author: sunpoet
>> Date: Thu Jul  9 15:48:58 2015
>> New Revision: 391655
>> URL: https://svnweb.freebsd.org/changeset/ports/391655
>>
>> Log:
>>   - Mark BROKEN on DragonFly BSD
>>   
>>   PR:		201341
>>   Submitted by:	marino
>>
>> Modified:
>>   head/databases/rocksdb/Makefile
>>
>> Modified: head/databases/rocksdb/Makefile
>> ==============================================================================
>> --- head/databases/rocksdb/Makefile	Thu Jul  9 15:44:50 2015	(r391654)
>> +++ head/databases/rocksdb/Makefile	Thu Jul  9 15:48:58 2015	(r391655)
>> @@ -25,6 +25,8 @@ USES=		compiler:c++11-lib gmake
>>  GH_ACCOUNT=	facebook
>>  USE_GITHUB=	yes
>>  
>> +BROKEN_DragonFly=	does not build on DragonFly BSD using GCC with -Werror
>> +
> 
> Normally you would just patch out -Werror, but in this case upstream
> added a convenient flag for that so you can add:
> 
> MAKE_ARGS= -DDISABLE_WARNING_AS_ERROR
> 
> If it's broken on DragonFly it's probably broken on FreeBSD too with
> modern GCC.
> 

It was there; sunpoet reverted that valid commit.
http://www.freshports.org/commit.php?category=databases&port=rocksdb&files=yes&message_id=201507041521.t64FLT91060382@repo.freebsd.org

Since I'm not playing his games, I requested the BROKEN.  (see PR if you
care)

John






Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?559EC2D7.5070004>