From nobody Sun Jun 27 02:04:37 2021
X-Original-To: python@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id AEFF411CABA1
	for <python@mlmmj.nyi.freebsd.org>; Sun, 27 Jun 2021 02:04:37 +0000 (UTC)
	(envelope-from bugzilla-noreply@freebsd.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (4096 bits) client-digest SHA256)
	(Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4GCDZY4HZgz4dD1
	for <python@FreeBSD.org>; Sun, 27 Jun 2021 02:04:37 +0000 (UTC)
	(envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(Client did not present a certificate)
	by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 7C3DD1C10
	for <python@FreeBSD.org>; Sun, 27 Jun 2021 02:04:37 +0000 (UTC)
	(envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org ([127.0.1.5])
	by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 15R24bd9060947
	for <python@FreeBSD.org>; Sun, 27 Jun 2021 02:04:37 GMT
	(envelope-from bugzilla-noreply@freebsd.org)
Received: (from www@localhost)
	by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 15R24bO0060946
	for python@FreeBSD.org; Sun, 27 Jun 2021 02:04:37 GMT
	(envelope-from bugzilla-noreply@freebsd.org)
X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f
From: bugzilla-noreply@freebsd.org
To: python@FreeBSD.org
Subject: [Bug 246328] [RESTORE] net-p2p/nicotine-plus: Graphical client for
 the Soulseek file sharing network
Date: Sun, 27 Jun 2021 02:04:37 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: feature, needs-patch, needs-qa
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: koobs@FreeBSD.org
X-Bugzilla-Status: Open
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org
X-Bugzilla-Flags: maintainer-feedback?
X-Bugzilla-Changed-Fields: keywords bug_severity flagtypes.name cc short_desc
Message-ID: <bug-246328-21822-X0n7ck79L5@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-246328-21822@https.bugs.freebsd.org/bugzilla/>
References: <bug-246328-21822@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
List-Id: FreeBSD-specific Python issues <freebsd-python.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/freebsd-python
List-Help: <mailto:python+help@freebsd.org>
List-Post: <mailto:python@freebsd.org>
List-Subscribe: <mailto:python+subscribe@freebsd.org>
List-Unsubscribe: <mailto:python+unsubscribe@freebsd.org>
Sender: owner-freebsd-python@freebsd.org
X-BeenThere: freebsd-python@freebsd.org
MIME-Version: 1.0
X-ThisMailContainsUnwantedMimeParts: N

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D246328

Kubilay Kocak <koobs@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |feature, needs-patch,
                   |                            |needs-qa
           Severity|Affects Many People         |Affects Only Me
              Flags|                            |maintainer-feedback?(menelk
                   |                            |ir@itroll.org)
                 CC|                            |python@FreeBSD.org
            Summary|[RESTORE]                   |[RESTORE]
                   |net-p2p/nicotine-plus: New  |net-p2p/nicotine-plus:
                   |maintainer                  |Graphical client for the
                   |                            |Soulseek file sharing
                   |                            |network

--- Comment #32 from Kubilay Kocak <koobs@FreeBSD.org> ---
Hi Daniel, thanks for updating the patch

A few review items:

COMMENT should match upstream setup.py:description modulo portlint
requirements:

    setup.py: description=3D"Graphical client for the Soulseek file sharing
network",

Use MASTER_SITES=3DCHEESESHOP if a Python package is registered on PyPI, un=
less
there is a compelling (temporary) case not to. [1]

Use PKGNAMEPREFIX, unless there is a compelling case not to. [2]

A dd python as a secondary category, unless there is a compelling reason not
to. [3]=20=20

Don't restrict USES=3Dpython:<version-spec> (currently only 3.8). <version-=
spec>
is declarative ("supports" <version-spec> versions) not imperative ("use"
<version-spec> versions). Upstream defines python_requires=3D'>=3D3.5', (se=
tup.py)
[4]

All dependency <version-spec>'s should be defined as completely and accurat=
ely
as possible to match upstreams declarations [5] . One example here is:=20

  setup.py: install_requires=3D['PyGObject>=3D3.18'],

Related: Where are the dependencies for mutagen/miniupnpc declares?

GH_* defaults to PORTNAME and PORTVERSION already, and are unnecessary:

  GH_PROJECT=3D   ${PORTNAME}
  GH_TAGNAME=3D   ${PORTVERSION}

Python ports should use autoplist and (concurrent where necessary) [6] unle=
ss
there is a compelling reason not to


Related, USE_PYTHON=3Dconcurrent must be used when a Python port installs f=
iles
that are not Python-version specific in shared locations [7]. This one does:

  bin/nicotine
  share/applications/*
  share/doc/*
  share/icons/*
  share/locale/*
  share/man/*
  share/metainfo/*

The default concurrent files list may not pick up some of the above, so you=
 may
need to add entries to UNIQUE_FILES / UNIQUE_DIRS or related variables. See:
/usr/ports/Mk/Uses/python.mk:concurrent and /usr/ports/Mk/Uses/uniquefile.mk

As far as what else would be good to progress this port, confirmation of QA
(portlint and poudriere) [8] would be great. Test with both the default and=
 a
non-default Python version

If you need help with respect to this port, porting in general or other Pyt=
hon
ports, just jump on our #freebsd-ports and/or #freebsd-python IRC [9] chann=
els.

[1] https://wiki.freebsd.org/Python/PortsPolicy#MASTER_SITES
[2] https://wiki.freebsd.org/Python/PortsPolicy#PKGNAMEPREFIX
[3] https://wiki.freebsd.org/Python/PortsPolicy#CATEGORIES
[4] https://wiki.freebsd.org/Python/PortsPolicy#USES.3Dpython
[5] https://wiki.freebsd.org/Python/PortsPolicy#Dependencies
[6] https://wiki.freebsd.org/Python/PortsPolicy#USE_PYTHON_Features
[7] https://wiki.freebsd.org/Python/PortsPolicy#concurrent
[8] https://docs.freebsd.org/en/books/porters-handbook/testing/
[9] https://wiki.freebsd.org/IRC/Channels

--=20
You are receiving this mail because:
You are on the CC list for the bug.=