Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 7 Aug 2024 21:27:28 +0300
From:      Dima Panov <fluffy@FreeBSD.org>
To:        Muhammad Moinur Rahman <bofh@FreeBSD.org>, ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   Re: git: 3b4c86ee5819 - main - www/php84-opcache: Unbreak
Message-ID:  <2457aba6-e7a5-48e7-a8e3-85395809134e@FreeBSD.org>
In-Reply-To: <202408022148.472LmR4E095984@gitrepo.freebsd.org>
References:  <202408022148.472LmR4E095984@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------hGwIC5cD2y0jevzvF7iv5y9l
Content-Type: multipart/mixed; boundary="------------tPXWDU9ZHj47ydqo2KCFjGqT";
 protected-headers="v1"
From: Dima Panov <fluffy@FreeBSD.org>
To: Muhammad Moinur Rahman <bofh@FreeBSD.org>, ports-committers@FreeBSD.org,
 dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Message-ID: <2457aba6-e7a5-48e7-a8e3-85395809134e@FreeBSD.org>
Subject: Re: git: 3b4c86ee5819 - main - www/php84-opcache: Unbreak
References: <202408022148.472LmR4E095984@gitrepo.freebsd.org>
In-Reply-To: <202408022148.472LmR4E095984@gitrepo.freebsd.org>

--------------tPXWDU9ZHj47ydqo2KCFjGqT
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hello!

On 03.08.2024 00:48, Muhammad Moinur Rahman wrote:
> The branch main has been updated by bofh:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=3b4c86ee58196188132b244feb893ea2864f704f
> 
> commit 3b4c86ee58196188132b244feb893ea2864f704f
> Author:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
> AuthorDate: 2024-08-02 21:47:45 +0000
> Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
> CommitDate: 2024-08-02 21:47:45 +0000
> 
>      www/php84-opcache: Unbreak
> ---
>   lang/php84/Makefile        | 9 ++++++++-
>   www/php84-opcache/Makefile | 2 --
>   2 files changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/lang/php84/Makefile b/lang/php84/Makefile
> index 795124262385..b2d4ea5987db 100644
> --- a/lang/php84/Makefile
> +++ b/lang/php84/Makefile

> @@ -593,6 +594,12 @@ USES+=			pkgconfig
>   CONFIGURE_ARGS+=--disable-opcache-jit
>   .endif
>   
> +.if ${PHP_MODNAME} == "opcache"
> +post-configure:
> +	@${BSDMAKE} -C ${WRKSRC} ./jit/ir/ir_fold_hash.h
> +	@${BSDMAKE} -C ${WRKSRC} ./jit/ir/ir_emit.lo
> +.endif
> +

On arch64 opcache-jit are always disabled (however, https://github.com/php/php-src/pull/12813 seem to be fixed it and we need to retest jit usage) and this construction fails to build.


Need to slightly modify it to skip manual jit handling on aarch64

-.if ${PHP_MODNAME} == "opcache"
+.if ${PHP_MODNAME} == "opcache" && ${ARCH} != aarch64




-- 
Sincerely,
Dima (fluffy@FreeBSD.org, https://t.me/FluffyBSD, @fluffy:matrix-dev.freebsd.org)
(desktop, kde, x11, office, ports-secteam)@FreeBSD team


--------------tPXWDU9ZHj47ydqo2KCFjGqT--

--------------hGwIC5cD2y0jevzvF7iv5y9l
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature.asc"

-----BEGIN PGP SIGNATURE-----

wsF5BAABCAAjFiEELTAsy5mEEwxvh7r8+4ugndU5jykFAmazvJAFAwAAAAAACgkQ+4ugndU5jyk8
cg/9HI+osMn0LXg1E5vigs/3wPW5lPWSMXshkbybg2U1hJDGP8uDzDtgyksZ/8gY/PtNlr6f39os
KTgeTVzpeqhfFXG7uSLBTw5I8NuyFDVryPtT+eesGB5ySQ9E8r6z3M39DCOyKu67J/IM08eK0dY/
OR1pj60ITt8ExdHxbrxtiu5zE7/CK/MjT7FrQ5XrJ/IZuzywBUtZyr3OUmjLLRBY78VcsuSK4zHo
CxPrjpCsgsw7mYsGVpVPwsVpe9mPGKC82ootK2umdH6sxg8ogZZ8AjmCCFO5z0qzWW4l5PJV4Z9e
t/i/AgyEMEkoBXcEeCHBg7gNH3777/JcCs4cCZOBJugahLGIlP/cWV7It68wnBxcfT1JthYKvDK8
3nmco2VqomR3nhkMFSyBgR6pplkeANShMfT3/Gf4MjWlerfTNPYwI7DNQK819vboW+vKekJ8lOUs
a95lYrRC9B0Px24CYNR98JroDxOU+0WuZXtJY551fY85jJycMBV5TB2Mby9c6AoYM80sX4PBeswc
erBLRDM4P1dtP+r+LOeWCH6UB7l8QUtpaGNLsJ7RLNixnkT9pjbCKax2g3i0aJok90qk5eHg4p38
oAWy1zUgFE7YEUh5W1ol2662MGnfxXLnzV3xfFUu00RW4bFwLiIvy8aZRwbvTiAtSEwMNE0ffLLb
Jmo=
=Ty20
-----END PGP SIGNATURE-----

--------------hGwIC5cD2y0jevzvF7iv5y9l--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2457aba6-e7a5-48e7-a8e3-85395809134e>