From owner-svn-ports-all@FreeBSD.ORG Thu May 30 18:24:55 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 9B9C64FA for ; Thu, 30 May 2013 18:24:55 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-pb0-x22e.google.com (mail-pb0-x22e.google.com [IPv6:2607:f8b0:400e:c01::22e]) by mx1.freebsd.org (Postfix) with ESMTP id 707D2BDC for ; Thu, 30 May 2013 18:24:55 +0000 (UTC) Received: by mail-pb0-f46.google.com with SMTP id rq2so818929pbb.19 for ; Thu, 30 May 2013 11:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=OV1ri+khwvRRSW5FN7OUA8GX38BR1lJCRIp+uNmajE0=; b=N2BNz1mj2FH5M/E6Ao2gtqO5HAy9LViaurG+qnmQ4yyVq+++wq+KPJyc+B5qMePojJ 6SfWYhg1fgtZhXx5vnpLBEbFPr0HQFtxhDnw1cg3GF3RRZdsWNqZEzrzq+S8gOGrx34l ZRo0GJcQ2+Kbxhg7cv6O60bRgUwOTWlhJZ1xM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=OV1ri+khwvRRSW5FN7OUA8GX38BR1lJCRIp+uNmajE0=; b=N53L9F5KETELmTG1f/Y/aOiPYTiOcpYf9zAuIzJ70SyZ2DGS6Al9JGDw1P0PEOny/9 fHB8+f0xNJTfEbGkFGkJu49Mi7joSTgJ+uGPqUWLRKx8h9IzWOXjZS9mj2+DM3kMkJ4+ YSDyUIXVR3DN5rit67pVrQSjRdukOI3GajItenUT4EzQDTqY/5a36eERS98hs+JFky3h bJyzPSid6gOT55bQfmbr6AnQ7hbeeS+BkqoTyZEIkmr0LWJ6t9N5OyrHPgK6Z4ZzXjYw 9CKxyV3N9iKB5hsWvkuMayJVzMqQ/TBtXJMxdMEsOe5Cv/3zuXkVnF+ntx49aiyGTk5i +nUQ== X-Received: by 10.68.219.130 with SMTP id po2mr9380494pbc.68.1369938295052; Thu, 30 May 2013 11:24:55 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.70.91.139 with HTTP; Thu, 30 May 2013 11:24:24 -0700 (PDT) In-Reply-To: References: <201305291541.r4TFf1PO037359@svn.freebsd.org> From: Eitan Adler Date: Thu, 30 May 2013 20:24:24 +0200 X-Google-Sender-Auth: oMRB4AOG9AocbNAUWy9dK-srZmQ Message-ID: Subject: Re: svn commit: r319380 - head/math/libtommath To: bf1783@gmail.com Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQkhtp2eYtacYIiaXwsVKmsSpNXxcQGdktw1Vx2EM0xLnKiXeTXmF8Q7HP3A4UQ8o81EBwZ3 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Martin Wilke X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 May 2013 18:24:55 -0000 On 30 May 2013 19:47, b.f. wrote: > On 5/30/13, Eitan Adler wrote: >> On 30 May 2013 03:42, Martin Wilke wrote: >>> >>> On May 30, 2013, at 5:17 AM, Eitan Adler wrote: >>> >>>> On 29 May 2013 17:41, Martin Wilke wrote: >>>>> Author: miwi >>>>> Date: Wed May 29 15:41:00 2013 >>>>> New Revision: 319380 >>>>> URL: http://svnweb.freebsd.org/changeset/ports/319380 >>>>> >>>>> Log: >>>>> - Disable regression test >>>>> >>>>> Reported by: pointyhat building 2(D)-02:56:27 >>>> >>>> This doesn't really explain what happened here. >>>> Did the regression test fail? Did the tests fail to build? Are there >>>> no regression tests? >>>> >>>> If the tests failed are they false positives, or do they indicate >>>> actual problems (where the port should be marked BROKEN)? >>>> >>> >>> the regression test hangs without timeout thats why i have disable it. >>> port it self builds fine no reason to mark it broken. >> >> Do the hangs indicate failure of the test program or failure of the >> actual program? >> If the latter it should be marked BROKEN. > > We don't automatically mark ports as BROKEN if they fail to pass a > test -- if we did, a great many more ports would be unavailable, > because most ports don't perform perfectly. Often test failures are > caused by the conditions in which the tests are run, or are due to > problems in the testsuite, or represent uncommon or minor problems > that should ultimately be fixed, but don't render the port useless in > the meantime. Please read what I asked carefully. Is the failure an indication of a broken program? BROKEN is not used just because a port fails its regression tests but it isn't reserved just for build failures. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams