From owner-svn-src-all@freebsd.org Fri Apr 29 16:40:48 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5E9B9B21497; Fri, 29 Apr 2016 16:40:48 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-oi0-f65.google.com (mail-oi0-f65.google.com [209.85.218.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2F8311BB1; Fri, 29 Apr 2016 16:40:47 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-oi0-f65.google.com with SMTP id i2so20108229oib.3; Fri, 29 Apr 2016 09:40:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :date:message-id:subject:from:to:cc; bh=/BtDGk0XSjWbDAYKODO2SFWyLB6OHw3GHZJ3sKopnBo=; b=VJpZcIf7avCW93a9cxr+21WJAdT+9777Ds/xjbIoOf7COQu2mKqV6nWBInEE5jOw4q LDhw/dkWLuNvPDDLvNJ29z9x1KcPKxpCYGsQkPkjjqZQJa7qmBgy1w48MNAduBNSRGLp ksIOfY/AzNsi0Z0TXr3g1SmeUTACMVG8N+vgva/IfQfvl03y0L5oyLw5lDIOikZsmMS0 t4NvsEvuTvIMLC6ToPttiuIIuxgK7QzKZ9pJAs+iIdgUiIYSZdOB43WrWa/+eJhoe04X DHYZPtGf1s3N3YTiDlMlQRq6Dn8JnhJ/cqr0Es1UNthnOHTnmxAGwAudcm0IW9ZbjWCT IYKQ== X-Gm-Message-State: AOPr4FUNdS3I3OkGEc5c+IQqO1w2G5DWpnM4IPp9Ybfy6QMihFS0ScE5cCTlZzNUxCBaQQ== X-Received: by 10.157.44.147 with SMTP id p19mr9956022otb.37.1461948041492; Fri, 29 Apr 2016 09:40:41 -0700 (PDT) Received: from mail-oi0-f54.google.com (mail-oi0-f54.google.com. [209.85.218.54]) by smtp.gmail.com with ESMTPSA id 67sm5852906otr.4.2016.04.29.09.40.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Apr 2016 09:40:41 -0700 (PDT) Received: by mail-oi0-f54.google.com with SMTP id k142so124731722oib.1; Fri, 29 Apr 2016 09:40:41 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.157.36.135 with SMTP id z7mr9456454ota.69.1461948040807; Fri, 29 Apr 2016 09:40:40 -0700 (PDT) Reply-To: cem@FreeBSD.org Received: by 10.157.6.111 with HTTP; Fri, 29 Apr 2016 09:40:40 -0700 (PDT) In-Reply-To: <201604291632.u3TGWSxg039148@repo.freebsd.org> References: <201604291632.u3TGWSxg039148@repo.freebsd.org> Date: Fri, 29 Apr 2016 09:40:40 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r298789 - in head/sys: kern sys From: Conrad Meyer To: "Pedro F. Giffuni" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Apr 2016 16:40:48 -0000 I think you'll want to remove them from the subsequent PRINT_BUF_FLAGS too. Best, Conrad On Fri, Apr 29, 2016 at 9:32 AM, Pedro F. Giffuni wrote: > Author: pfg > Date: Fri Apr 29 16:32:28 2016 > New Revision: 298789 > URL: https://svnweb.freebsd.org/changeset/base/298789 > > Log: > bufs: make B_DIRTY and B_PERSISTENT flags available > > It appears these flags were related to ext2fs but are completely > unused nowadays. Retire them. > > Suggested by: mckusick > > Modified: > head/sys/kern/vfs_bio.c > head/sys/sys/buf.h > > Modified: head/sys/kern/vfs_bio.c > ============================================================================== > --- head/sys/kern/vfs_bio.c Fri Apr 29 16:07:25 2016 (r298788) > +++ head/sys/kern/vfs_bio.c Fri Apr 29 16:32:28 2016 (r298789) > @@ -1162,8 +1162,7 @@ vfs_buf_check_unmapped(struct buf *bp) > static int > isbufbusy(struct buf *bp) > { > - if (((bp->b_flags & (B_INVAL | B_PERSISTENT)) == 0 && > - BUF_ISLOCKED(bp)) || > + if (((bp->b_flags & B_INVAL) == 0 && BUF_ISLOCKED(bp)) || > ((bp->b_flags & (B_DELWRI | B_INVAL)) == B_DELWRI)) > return (1); > return (0); > > Modified: head/sys/sys/buf.h > ============================================================================== > --- head/sys/sys/buf.h Fri Apr 29 16:07:25 2016 (r298788) > +++ head/sys/sys/buf.h Fri Apr 29 16:32:28 2016 (r298789) > @@ -200,7 +200,7 @@ struct buf { > #define B_CACHE 0x00000020 /* Bread found us in the cache. */ > #define B_VALIDSUSPWRT 0x00000040 /* Valid write during suspension. */ > #define B_DELWRI 0x00000080 /* Delay I/O until buffer reused. */ > -#define B_PERSISTENT 0x00000100 /* Perm. ref'ed while EXT2FS mounted. */ > +#define B_00000100 0x00000100 /* Available flag. */ > #define B_DONE 0x00000200 /* I/O completed. */ > #define B_EINTR 0x00000400 /* I/O was interrupted */ > #define B_NOREUSE 0x00000800 /* Contents not reused once released. */ > @@ -213,7 +213,7 @@ struct buf { > #define B_00040000 0x00040000 /* Available flag. */ > #define B_00080000 0x00080000 /* Available flag. */ > #define B_00100000 0x00100000 /* Available flag. */ > -#define B_DIRTY 0x00200000 /* Needs writing later (in EXT2FS). */ > +#define B_00200000 0x00200000 /* Available flag. */ > #define B_RELBUF 0x00400000 /* Release VMIO buffer. */ > #define B_FS_FLAG1 0x00800000 /* Available flag for FS use. */ > #define B_NOCOPY 0x01000000 /* Don't copy-on-write this buf. */ >