Date: Tue, 3 May 2011 12:36:51 -0700 From: Maksim Yevmenkin <maksim.yevmenkin@gmail.com> To: David Demelier <demelier.david@gmail.com> Cc: freebsd-bluetooth@freebsd.org Subject: Re: Bluetooth mouse does not connect after reboot Message-ID: <BANLkTimHnsfCBob_DByxMd3CjtKw7K41LA@mail.gmail.com> In-Reply-To: <4DC0563D.7080005@gmail.com> References: <4D3889D2.80508@gmail.com> <201101202043.p0KKhDIB076736@lurza.secnetix.de> <AANLkTindTyEBAgGV3cBcSs6tGMtN8JtQ3_sHOF4n%2BnEs@mail.gmail.com> <4DBF0D26.8020703@gmail.com> <BANLkTi=dYv5R6jkqNhTj6m%2BZHK=afLXvow@mail.gmail.com> <4DC0513A.5000805@gmail.com> <BANLkTikeiZ61NwRSRh7xNqMTy97soxjc_A@mail.gmail.com> <4DC0563D.7080005@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Tue, May 3, 2011 at 12:23 PM, David Demelier
<demelier.david@gmail.com> wrote:
>>>>> I'm sorry to disturb you again.. I'm still guessin where to search how
>>>>> to
>>>>> get these horizontal events with my bluetooth mouse. I thing the
>>>>> mouse_info
>>>>> structure does not need to be extended I have a USB mouse that has the
>>>>> same
>>>>> horizontal buttons and they just works !
>>>>>
>>>>> They sends 7 and 8 events to X (checked with xev)
>>>>>
>>>>> What can I do to extend bthidd and this button support ?
>>>>
>>>> like i said before, you need to decode AC_Pan data from the report. i
>>>> just took a quick look at ums(4) driver and, it appears, that AC_Pan
>>>> events are translated into button events, i.e. values< 0 is mask (1
>>>> << 3) and values> 0 is mask (1<< 4) . you can add identical
>>>> translation to bthidd(8) to see if it works. you will need to modify
>>>> hid_interrupt() function in hid.c
>>>
>>> Max,
>>>
>>> I successfully made the patch but it's not the same mask. This diff just
>>> works!
>>>
>>> --- hid.c.orig 2011-05-02 22:09:48.000000000 +0200
>>> +++ hid.c 2011-05-03 20:57:46.000000000 +0200
>>> @@ -168,6 +168,16 @@
>>> usage = HID_USAGE(h.usage);
>>> val = hid_get_data(data,&h);
>>>
>>> + /* Horizontal buttons */
>>> + if (page == HUP_CONSUMER&& usage == HUC_AC_PAN) {
>>> + if (val< 0)
>>> + mouse_butt |= (1<< 5);
>>> + else if (val> 0)
>>> + mouse_butt |= (1<< 6);
>>> +
>>> + mevents ++;
>>> + }
>>> +
>>> switch (page) {
>>> case HUP_GENERIC_DESKTOP:
>>> switch (usage) {
>>>
>>> Do you think it's a diff suitable to commit ?
>>>
>>> I'm so happy to make my horizontal buttons working :):)
>>
>> ah, i see you already figured it out :) i can commit something like
>> this, i suppose. i would just move the statement into switch() below.
>> i suppose we could just document that ac_pan is encoded as 8 and 9
>> button presses.
>>
>
> Yes but why is the mask different from the ums ones ? Also can you commit
> this to -STABLE thus I'll be able to use it without patching it.
i *think* its because usb mouse operates on level1 (see mouse(4) for
details), and, status for "extended" mouse buttons reported
separately, i.e. from mouse(4) man page: byte 8, bits 0-6 reflect the
state of the buttons 4-10.
i can not commit this directly to -stable. i need to commit this to
-head first and then mfc it after a week or so.
i'm attaching a slightly different patch (dont worry you still get all
the credit). please try it and let me know if it works for you.
thanks,
max
[-- Attachment #2 --]
Index: hid.c
===================================================================
--- hid.c (revision 221400)
+++ hid.c (working copy)
@@ -229,6 +229,16 @@
break;
switch (usage) {
+ case HUC_AC_PAN:
+ /* Horizontal scroll */
+ if (val < 0)
+ mouse_butt |= (1 << 5);
+ else
+ mouse_butt |= (1 << 6);
+
+ mevents ++;
+ break;
+
case 0xb5: /* Scan Next Track */
val = 0x19;
break;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTimHnsfCBob_DByxMd3CjtKw7K41LA>