From nobody Tue Aug 1 01:16:52 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RFHJt4lrjz4pdwJ for ; Tue, 1 Aug 2023 01:17:08 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RFHJb1m4Xz42jw for ; Tue, 1 Aug 2023 01:17:03 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20221208 header.b=b6Tq5zoj; spf=pass (mx1.freebsd.org: domain of rick.macklem@gmail.com designates 2607:f8b0:4864:20::22e as permitted sender) smtp.mailfrom=rick.macklem@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-oi1-x22e.google.com with SMTP id 5614622812f47-3a43cbb432aso3746839b6e.3 for ; Mon, 31 Jul 2023 18:17:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690852622; x=1691457422; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=pAWIA5K2zZJz3/lUJIn9YATCisJRJbG26BiMdpwKiqc=; b=b6Tq5zoj4db9nanVE71yUibQ0w/PrZEqwAZdQZsWf0dH9rWDBRyNUkejALQX7Pqm98 9KB9mHrfBpBLv3fD4LYFoLWf/s/E5B3gjyiFvaE25m7VsoCM9DosnVR23vPj/r0BpQr1 2Pty331NwIoQwa0l9NBlG6JUH79BE6IdXDZrWy+mPIGzst/R6R0XWS7F/2jBhlFaSW4w 5EwnZQopr1yfS0y7FOKL8xZya/XMxg24h04va5EP0eMrt6y+Yz5Xv9+icRf1uEGNxcQB 9mHffwczhPpK19VaLuU/kbzqMdIQf2cWcqH91RuXMKK8Umvut5tyIUxl8cRwdQK4n9LE FW0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690852622; x=1691457422; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pAWIA5K2zZJz3/lUJIn9YATCisJRJbG26BiMdpwKiqc=; b=HoHlGOHBshy10KMFgW+TZMthM+/509AUIleogQW5lOMHU0qJvPAM72acdjtiXoWuIL tNpf5eg+Rf7e5CtZ73ebQ8Q6BxYCSfNXWn94d6B24b2BVGy04Fj2u61n8uJiStWE6CAE BCKi9qydigoiUT+VPCMKUc+XjK275o9RDuybQc9IueR15FxyhWzyI+sD3LNNZkA+tVYH gcfVH2jydOqLEFGYF3tk71f/+yWy71xJGhHqAAVeG4VhFYKqU6CCHS0ZSj0m4BN9K/gK 0c7QldxFpuJga20JYD8voGcBm4gE+Ni2IfO1IQIJD/GmCsF1EVxxvpLVy7KTfZTvAY4p EEaQ== X-Gm-Message-State: ABy/qLaL/CPf+giwyk/jSJDtoP5525xDXP6Cilr5X9DaACy91KkIIffO 2GfU/KqgnnU5dTG6qKTlvyBQ3e3Ev10z8LvJWZngBM8AfA== X-Google-Smtp-Source: APBJJlG67qpXAqs9hHEYWtRN0Cl7buAHi+ckn2YXBKUFM67TGa8ilvEl9n3I7FVh1mgq7ApDKAIfnYT8s/YI58BcuYU= X-Received: by 2002:a05:6808:203:b0:3a4:8086:bb9f with SMTP id l3-20020a056808020300b003a48086bb9fmr12124037oie.18.1690852621759; Mon, 31 Jul 2023 18:17:01 -0700 (PDT) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 From: Rick Macklem Date: Mon, 31 Jul 2023 18:16:52 -0700 Message-ID: Subject: Review of patch that uses "volatile sig_atomic_t" To: FreeBSD CURRENT Content-Type: text/plain; charset="UTF-8" X-Spamd-Result: default: False [-3.25 / 15.00]; NEURAL_HAM_SHORT(-0.99)[-0.992]; NEURAL_HAM_LONG(-0.94)[-0.937]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_MEDIUM(-0.32)[-0.319]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20221208]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; RCPT_COUNT_ONE(0.00)[1]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::22e:from]; ARC_NA(0.00)[]; TAGGED_FROM(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; DKIM_TRACE(0.00)[gmail.com:+]; TO_DN_ALL(0.00)[]; MID_RHS_MATCH_FROMTLD(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4RFHJb1m4Xz42jw X-Spamd-Bar: --- Hi, I just put D41265 up on phabricator. It is a trivial change to mountd.c that defines the variable set by got_sighup() (the SIGHUP handler) as static volatile sig_atomic_t instead of static int I did list a couple of reviewers, but if you are familiar with this C requirement, please take a look at it and review it. Thanks, rick ps: I was unaware of this C requirement until Peter Eriksson reported it to me yesterday. Several of the other NFS related daemons probably need to same fix, which I will do after this is reviewed.