Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 31 Jul 2023 18:16:52 -0700
From:      Rick Macklem <rick.macklem@gmail.com>
To:        FreeBSD CURRENT <freebsd-current@freebsd.org>
Subject:   Review of patch that uses "volatile sig_atomic_t"
Message-ID:  <CAM5tNy5aAyRk_CML57Q7OEPXGVEjM=o8fqWdLJCRkHubBYzCNQ@mail.gmail.com>

next in thread | raw e-mail | index | archive | help
Hi,

I just put D41265 up on phabricator. It is a trivial
change to mountd.c that defines the variable set
by got_sighup() (the SIGHUP handler) as
   static volatile sig_atomic_t
instead of
    static int

I did list a couple of reviewers, but if you are familiar
with this C requirement, please take a look at it and
review it.

Thanks, rick
ps: I was unaware of this C requirement until Peter Eriksson
      reported it to me yesterday. Several of the other NFS
      related daemons probably need to same fix, which I will
      do after this is reviewed.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAM5tNy5aAyRk_CML57Q7OEPXGVEjM=o8fqWdLJCRkHubBYzCNQ>