From owner-freebsd-audit  Fri Jun 22  9:37:58 2001
Delivered-To: freebsd-audit@freebsd.org
Received: from relay.nuxi.com (nuxi.cs.ucdavis.edu [169.237.7.38])
	by hub.freebsd.org (Postfix) with ESMTP
	id E720D37B401; Fri, 22 Jun 2001 09:37:55 -0700 (PDT)
	(envelope-from obrien@nuxi.ucdavis.edu)
Received: from dragon.nuxi.com (root@trang.nuxi.com [206.40.252.115])
	by relay.nuxi.com (8.11.2/8.11.2) with ESMTP id f5MGbtR16003;
	Fri, 22 Jun 2001 09:37:55 -0700 (PDT)
	(envelope-from obrien@NUXI.com)
Received: (from obrien@localhost)
	by dragon.nuxi.com (8.11.3/8.11.1) id f5MGbs638644;
	Fri, 22 Jun 2001 09:37:54 -0700 (PDT)
	(envelope-from obrien)
Date: Fri, 22 Jun 2001 09:37:54 -0700
From: "David O'Brien" <obrien@freebsd.org>
To: Mike Barcroft <mike@q9media.com>
Cc: Mike Heffner <mheffner@vt.edu>, phk@freebsd.org,
	freebsd-audit@freebsd.org
Subject: Re: whois(1) patch
Message-ID: <20010622093754.B38146@dragon.nuxi.com>
Reply-To: obrien@freebsd.org
References: <20010622033201.B506@dragon.nuxi.com> <B758EB5A.D6C%mike@q9media.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <B758EB5A.D6C%mike@q9media.com>; from mike@q9media.com on Fri, Jun 22, 2001 at 12:32:26PM -0400
X-Operating-System: FreeBSD 5.0-CURRENT
Organization: The NUXI BSD group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

On Fri, Jun 22, 2001 at 12:32:26PM -0400, Mike Barcroft wrote:
> > You should separate your patches into functionality and style(9).
> > I see DES just committed this patch as is, rather than break it into two
> > parts as our practices says it should have been.
> 
> Sorry.  I'll make sure I do this in future.

Thanks! :-)
 
> > You also changed puts() to printf().  Was there a reason for making that
> > change?
> 
> style(9):
>      Use printf(3), not fputs/puts/putchar/whatever; it's faster and usually
>      cleaner, not to mention avoiding stupid bugs.

Ah, I've missed that one.  I haven't noticed anyone else do
s/puts/printf/g in the name of style(9) before.

-- 
-- David  (obrien@FreeBSD.org)

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message