From owner-freebsd-perl@FreeBSD.ORG  Fri Feb  4 08:59:38 2005
Return-Path: <owner-freebsd-perl@FreeBSD.ORG>
Delivered-To: freebsd-perl@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CA3EF16A4CE
	for <freebsd-perl@freebsd.org>; Fri,  4 Feb 2005 08:59:38 +0000 (GMT)
Received: from heechee.tobez.org (heechee.tobez.org [217.157.39.226])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E552543D45
	for <freebsd-perl@freebsd.org>; Fri,  4 Feb 2005 08:59:35 +0000 (GMT)
	(envelope-from tobez@tobez.org)
Received: by heechee.tobez.org (Postfix, from userid 1001)
	id 3B8F5125467; Fri,  4 Feb 2005 09:59:34 +0100 (CET)
Date: Fri, 4 Feb 2005 09:59:34 +0100
From: Anton Berezin <tobez@FreeBSD.org>
To: Daren Desjardins <desjardins@canada.com>
Message-ID: <20050204085934.GA52914@heechee.tobez.org>
References: <4200F3B3.7050706@canada.com>
	<813911377.1107434232.147437664.80111@mcgi2.rambler.ru>
	<20050203124845.GD15084@heechee.tobez.org> <420235E6.3030206@canada.com>
	<20050204002750.GA38458@heechee.tobez.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050204002750.GA38458@heechee.tobez.org>
User-Agent: Mutt/1.4.2.1i
cc: freebsd-perl@freebsd.org
Subject: Re: Perl 5.8.6 upgrade
X-BeenThere: freebsd-perl@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: maintainer of a number of perl-related ports
	<freebsd-perl.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-perl>,
	<mailto:freebsd-perl-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-perl>
List-Post: <mailto:freebsd-perl@freebsd.org>
List-Help: <mailto:freebsd-perl-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-perl>,
	<mailto:freebsd-perl-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Feb 2005 08:59:38 -0000

On Fri, Feb 04, 2005 at 01:27:50AM +0100, Anton Berezin wrote:

> Please test.

> # $Id: perl-after-upgrade,v 1.6 2005/02/04 00:24:43 tobez Exp $

There is actually a file permission bug in the script.  The following
patch fixes that:

Index: perl-after-upgrade
===================================================================
RCS file: /home/tobez/.local./cvs/FreeBSD-perl-tools/perl-after-upgrade,v
retrieving revision 1.6
diff -u -r1.6 perl-after-upgrade
--- perl-after-upgrade	4 Feb 2005 00:24:43 -0000	1.6
+++ perl-after-upgrade	4 Feb 2005 08:57:34 -0000
@@ -285,6 +285,7 @@
 				close $fh;
 				$new_md5 = `/sbin/md5 -q $fn`;
 				chomp $new_md5;
+				my $mode = (stat($file))[2] & 07777;
 				unlink $file or do {
 					push @errors, "Failed to unlink $file: $!";
 					unlink $fn;
@@ -294,6 +295,7 @@
 					push @errors, "Failed to rename $fn to $file: $!";
 					return "";
 				};
+				chmod $mode, $file;
 			} else {
 				push @errors, "Failed to modify $file: $!";
 			}

\Anton.
-- 
The moronity of the universe is a monotonically increasing function. --
Jarkko Hietaniemi