From owner-svn-src-all@freebsd.org Fri Nov 24 19:17:21 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EDDA0DEEF04; Fri, 24 Nov 2017 19:17:21 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 806DD80D80; Fri, 24 Nov 2017 19:17:21 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id vAOJHHSK096734; Fri, 24 Nov 2017 11:17:17 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id vAOJHHrA096733; Fri, 24 Nov 2017 11:17:17 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201711241917.vAOJHHrA096733@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r326169 - in head: . contrib/ofed lib/libc/locale share/mk sys/amd64/amd64 sys/amd64/conf sys/conf sys/contrib/rdma/krping sys/dev/cxgbe sys/dev/cxgbe/common sys/dev/cxgbe/iw_cxgbe sys/... In-Reply-To: <4695efa6-c8d5-e860-3c9b-939ac4b91abc@selasky.org> To: Hans Petter Selasky Date: Fri, 24 Nov 2017 11:17:17 -0800 (PST) CC: Mark Johnston , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Nov 2017 19:17:22 -0000 [ Charset UTF-8 unsupported, converting... ] > On 11/24/17 18:35, Mark Johnston wrote: > > On Fri, Nov 24, 2017 at 06:29:25PM +0100, Hans Petter Selasky wrote: > >> On 11/24/17 18:22, Mark Johnston wrote: > >>> On Fri, Nov 24, 2017 at 06:09:25PM +0100, Hans Petter Selasky wrote: > >>>> On 11/24/17 16:00, Mark Johnston wrote: > >>>>> Are there non-trivial interoperability issues between mthca and the > >>>>> updated OFED stack? If so, could you describe them? If not, I would > >>>>> strongly prefer to retain the mthca driver, as Isilon still has plenty > >>>>> of hardware making use of it. > >>>> > >>>> Hi, > >>>> > >>>> There are no technical reasons except Mellanox hasn't focused on the > >>>> mthca driver in this upgrade. With little effort you should be able to > >>>> pull libmthca and the mthca driver from the mentioned sources and make > >>>> it work. > >>> > >>> In that case, could we please bring it back in to svn? It seems silly to > >>> remove a driver just because it's not being actively maintained: that > >>> isn't the bar for keeping drivers in FreeBSD, and I note that mthca is > >>> still present in Linux. If there is some work needed to get the kernel > >>> and userland components to compile again, I'm happy to do it; I just > >>> don't want to have to maintain an out-of-tree HCA driver when there's no > >>> good reason it can't stay in svn. > >>> > >> > >> Sure, but we probably want to put it into sys/dev/mthca instead of > >> sys/ofed/xxx . > > > > Ok. > > > >> Are you saying you want to pull it in yourself and make > >> it compile? > > > > I don't really *want* to, but I will if you don't. :) > > > > Let me discuss this at Mellanox first. I'll get back to you on Monday on > this topic. Just to add some input I would also like to see the mthca drive continue to live as a pair of them is part of my test bed here. But, I can understand these are pretty old products, and that they can be replaced for a sub $20.00 price off of ebay. (I already have a collection of Connectx-3 cards supported by mlx4 drivers.) -- Rod Grimes rgrimes@freebsd.org