From owner-svn-src-projects@freebsd.org Fri Feb 28 00:54:11 2020 Return-Path: Delivered-To: svn-src-projects@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0829F255237 for ; Fri, 28 Feb 2020 00:54:11 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: from mail-oi1-x244.google.com (mail-oi1-x244.google.com [IPv6:2607:f8b0:4864:20::244]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48T9z65CSwz3DS0; Fri, 28 Feb 2020 00:54:10 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: by mail-oi1-x244.google.com with SMTP id l12so1221861oil.9; Thu, 27 Feb 2020 16:54:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iutQfx8JymobB/Q0ltv9u2YPIZH/qxPtkP/PgpvaZZA=; b=Ye6l4Wv/bjnHxmnJ/BEI5N0z9uSgBfOjedp9x2j9TltYjF7s37dkvPKnzO6TPH5lOX Qbq9cYoQMqbEwVCyTaHeDXPycnt0fBM2nMq1hD3wLz8J3N9W8j+Bu4Xg6QErxW77CBaF FwEd+1OGdsXv7k2MLz9luXc294knqx1QGriF8o6brsXLTQ0SKjgCi/Jcka13OwmM4EOW pfMRgRsiDzQqxFJgtTFTmxnb60ANwuK/g6OZWRuFOpCqB2nxXO0W6L9WoI2UYTH9VFGj tLCp4P4zOG8WV6bwdCKt32BypDfDCYnls7/LV/rOYD7lMlGOatDC9BMAuGZNGz58h4EV BeAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iutQfx8JymobB/Q0ltv9u2YPIZH/qxPtkP/PgpvaZZA=; b=WYlMzAueqR/vUjQMhWGthY+pUm1ltXmfuTUIsMIE+Qa5hpXZiwJR/hMhLLBnP8T9Ri mZfPk5H4+c9lxoCokqzI38WBJ0DPdPcEEmDkqBMljgwMIeF6KqEFEKIZuQDyCB5LB5rY MsyCnZC/OvkTkyjtZjdva4oJATZb1LBKrN/ofO8WegpWgnjy7iK9y4cyLbVMoip2NspK fpJkrSqRsTiKvvCwOkWek65kJ5X4SwPUx32T8uFB7lwlPZBj4iffpasATpCm68A5Qaqa OPBm7yDOuLY2R6Ategxow/IzuN1NEmcUKZAAi93Ef3peeAEwCr0HQnzQ57VZqx652r/a 418g== X-Gm-Message-State: APjAAAV+5ITlP9gobK4etvFyv4Wyd4MLUWGPgcGKxxWNl6kViUrs6a79 jTt6Zw+enUnw5ECPRXlQeRPdFVjicybZRx7HuhmKOdzW X-Google-Smtp-Source: APXvYqwGOq7jjqfyOFhbwwNuQps9qBZpgWTbbFjxHp5K5yleFhaDWYmqv56lTdifpJr/9mVRDy5RxALXJELVcyzIy7o= X-Received: by 2002:a05:6808:346:: with SMTP id j6mr1404512oie.47.1582851249001; Thu, 27 Feb 2020 16:54:09 -0800 (PST) MIME-Version: 1.0 References: <202002172110.01HLAXZY003012@repo.freebsd.org> In-Reply-To: From: Benjamin Kaduk Date: Thu, 27 Feb 2020 16:53:58 -0800 Message-ID: Subject: Re: svn commit: r358053 - projects/nfs-over-tls/sys/fs/nfsclient To: John Baldwin Cc: Rick Macklem , src-committers , svn-src-projects@freebsd.org X-Rspamd-Queue-Id: 48T9z65CSwz3DS0 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Feb 2020 00:54:11 -0000 On Thu, Feb 27, 2020 at 4:49 PM John Baldwin wrote: > On 2/17/20 1:10 PM, Rick Macklem wrote: > > Author: rmacklem > > Date: Mon Feb 17 21:10:32 2020 > > New Revision: 358053 > > URL: https://svnweb.freebsd.org/changeset/base/358053 > > > > Log: > > Update nfs_clrpcops.c to handle ext_pgs mbufs, including the additional > > argument to nfscl_reqstart() to tell it if it should build ext_pgs > mbufs. > > > > This completes most of the conversion to support of ext_pgs mbufs, but > > there are still a couple of areas to fix. > > 1 - The code that the MDS uses to do a proxy to a DS for a pNFS server. > > 2 - The krpc code on the receive side. (The NFS code now handles the > > ext_pgs mbufs, but they are being created by copying the regular > mbuf > > list when the NFS code gets it from the krpc.) The krpc still needs > > to be fixed so it can handle a list of ext_pgs mbufs handed to it > > by soreceive(). > > Note that the current KTLS RX support I've worked on is a bit different in > that > it doesn't use ext_pgs mbufs. Instead the socket buffer contains a list of > records (OpenSSL uses recvmsg()) where there is a control mbuf with the TLS > header followed by a chain of normal mbufs with the data. As such, you > will > only have to construct ext_pgs mbufs for the send side. Receive will still > be getting regular mbufs. For receive you probably want to check the TLS > record type and do something (not sure?) with any non-application-data > records, > but otherwise just treat the payload of application-data records the same > as > you do for the non-TLS case. > > Yes, you need to check the record type. I assume that kTLS is still going to pass you TLS handshake records (e.g., TLS 1.3 session tickets) that should be processed by openssl. (Hmm, TLS 1.3 KeyUpdate might present a synchronization problem, though I am not sure how kTLS is set up for that.) -Ben