From owner-freebsd-current@FreeBSD.ORG Thu Aug 26 03:36:42 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 12A7616A4CE; Thu, 26 Aug 2004 03:36:42 +0000 (GMT) Received: from kientzle.com (h-66-166-149-50.snvacaid.covad.net [66.166.149.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 016B643D41; Thu, 26 Aug 2004 03:36:41 +0000 (GMT) (envelope-from kientzle@freebsd.org) Received: from freebsd.org (p54.kientzle.com [66.166.149.54]) by kientzle.com (8.12.9/8.12.9) with ESMTP id i7Q3aZ90027211; Wed, 25 Aug 2004 20:36:36 -0700 (PDT) (envelope-from kientzle@freebsd.org) Message-ID: <412D5AC3.6090103@freebsd.org> Date: Wed, 25 Aug 2004 20:36:35 -0700 From: Tim Kientzle User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.4) Gecko/20031006 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Sean McNeil References: <1092777586.92327.9.camel@server.mcneil.com> <1093369220.10362.6.camel@server.mcneil.com> <20040824200225.V517@beagle.kn.op.dlr.de> <1093371600.10464.23.camel@server.mcneil.com> <20040824205417.L517@beagle.kn.op.dlr.de> <1093377802.43728.11.camel@server.mcneil.com> <1093385848.84723.2.camel@server.mcneil.com> <20040825181730.GJ53710@dragon.nuxi.com> <1093460556.82060.5.camel@server.mcneil.com> In-Reply-To: <1093460556.82060.5.camel@server.mcneil.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: Giorgos Keramidas cc: Harti Brandt cc: current@freebsd.org Subject: Re: bsdtar core dumps X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Aug 2004 03:36:42 -0000 Sean McNeil wrote: > On Wed, 2004-08-25 at 11:17, David O'Brien wrote: > >>On Tue, Aug 24, 2004 at 03:17:28PM -0700, Sean McNeil wrote: >> >>>>>SM>> You cannot use a va_list twice. As soon as someone call >>>>>va_arg() on the SM>> ap all the aps in the calling functions get >>>>>invalid. The only thing that SM>> can and must be done is that the >>>>>function that did the va_start() must SM>> call va_end. >> >>... >> >>>I missed one in vfwprintf.c. I needs a va_end(orgap) just like above. >>> >>>Also, I've searched all of src and found one additional place that there >>>is a va_copy without a va_end. >>> >>>contrib/gnu-sort/lib/version-etc.c >>> >>>All other uses appear to be properly matched. >> >>Can you please make a new, complete patch? >>I'll commit it ASAP. > > Thanks David, > > Here are are the patches of all unmatched/missing va_copy/va_end and > core dump fix to libarchive: Since David hasn't had a chance to do this yet, I've gone ahead and committed the libarchive fix. If David doesn't beat me to it, I'll get the rest of it committed in the next couple of hours. Thanks so much for your hard work on this, Sean. Tim