From owner-cvs-all Sat Dec 22 18:33:53 2001 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 4D0EB37B416; Sat, 22 Dec 2001 18:33:48 -0800 (PST) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id NAA05920; Sun, 23 Dec 2001 13:33:45 +1100 Date: Sun, 23 Dec 2001 13:33:53 +1100 (EST) From: Bruce Evans X-X-Sender: To: Matt Dillon Cc: , Subject: Re: cvs commit: src/sys/dev/sio sio.c In-Reply-To: <200112230048.fBN0mb624793@freefall.freebsd.org> Message-ID: <20011223132947.K10139-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, 22 Dec 2001, Matt Dillon wrote: > dillon 2001/12/22 16:48:37 PST > > Modified files: > sys/dev/sio sio.c > Log: > This problem has been in the serial driver for years, and I occassionally > see people trip over it. Do not set the FIFO trigger to just before it > would otherwise overflow. Give it a little more slop so characters aren't > lost if the interrupt is delayed by other system activities. > > MFC maybe: 7 days > > Revision Changes Path > 1.354 +6 -1 src/sys/dev/sio/sio.c This setting is intentional. The default setting provides twice as much slop as the 8250 UARTs which the driver was designed to support on systems hundreds of times slower than current ones. Making it twice as large again doesn't help much. This commit will was not approved or even sent for review to the maintainer and will be backed out in a minute. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message