From owner-svn-src-all@FreeBSD.ORG Sat Feb 21 00:51:04 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A8215807; Sat, 21 Feb 2015 00:51:04 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 3319B5EB; Sat, 21 Feb 2015 00:51:02 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t1L0opbP091218 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 21 Feb 2015 03:50:51 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t1L0opxT091217; Sat, 21 Feb 2015 03:50:51 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Sat, 21 Feb 2015 03:50:51 +0300 From: Gleb Smirnoff To: Bruce Simpson Subject: Re: svn commit: r279028 - in head/usr.sbin: . ifmcstat Message-ID: <20150221005051.GT15484@FreeBSD.org> References: <201502192242.t1JMgY3e045902@svn.freebsd.org> <54E6A68B.1090609@fastmail.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54E6A68B.1090609@fastmail.net> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Feb 2015 00:51:04 -0000 Bruce, On Fri, Feb 20, 2015 at 03:14:19AM +0000, Bruce Simpson wrote: B> Gleb, B> B> Correct me if I'm wrong -- but doesn't this set of changes remove the B> ability for the user to see the stack-wide membership filters on each B> link? The implementation required KVM as it must inspect the SSM filters B> themselves to obtain this information. Can you point me at the code please? I see that both kvm(3) or API based code call in6_ifinfo() or in_ifinfo(). May be you refer to code that was always under #if 0, disabled due to difficulty to go through RB-trees via kvm(3)? B> On 19/02/2015 22:42, Gleb Smirnoff wrote: B> > Now that IGMP and MLD sysctls provide a clean API structures that do not B> > leak kernel internal stuff, reconnect ifmcstat(1) back to build. B> B> The change is well motivated, but the job is only half done. B> B> The backend code you have added simply reflects the per-link information B> to userland as a flat data structure; it does not appear to report what B> the membership filters are. B> B> This would require taking a lock, walking the RB-tree for the in-mode B> filters, and serializing the data to userland as a variable length B> structure. I can do that, if you provide me with details. But I'd really appreciate, if you do that :) -- Totus tuus, Glebius.