From owner-freebsd-bugs@FreeBSD.ORG Fri Jan 30 02:00:41 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6040516A4FD for ; Fri, 30 Jan 2004 02:00:41 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 05A8143D46 for ; Fri, 30 Jan 2004 02:00:35 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i0UA0YFR050293 for ; Fri, 30 Jan 2004 02:00:34 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i0UA0YpV050292; Fri, 30 Jan 2004 02:00:34 -0800 (PST) (envelope-from gnats) Resent-Date: Fri, 30 Jan 2004 02:00:34 -0800 (PST) Resent-Message-Id: <200401301000.i0UA0YpV050292@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Divacky Roman Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 35CC116A4CF for ; Fri, 30 Jan 2004 01:59:38 -0800 (PST) Received: from eva.fit.vutbr.cz (eva.fit.vutbr.cz [147.229.10.14]) by mx1.FreeBSD.org (Postfix) with ESMTP id D572343D1D for ; Fri, 30 Jan 2004 01:59:35 -0800 (PST) (envelope-from xdivac02@stud.fit.vutbr.cz) Received: from eva.fit.vutbr.cz (localhost [127.0.0.1]) by eva.fit.vutbr.cz (8.12.11/8.12.9) with ESMTP id i0U9xWlU010735 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO) for ; Fri, 30 Jan 2004 10:59:32 +0100 (CET) Received: (from xdivac02@localhost) by eva.fit.vutbr.cz (8.12.11/8.12.5/Submit) id i0U9xWPZ010734; Fri, 30 Jan 2004 10:59:32 +0100 (CET) Message-Id: <200401300959.i0U9xWPZ010734@eva.fit.vutbr.cz> Date: Fri, 30 Jan 2004 10:59:32 +0100 (CET) From: Divacky Roman To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: kern/62102: obreak update X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Divacky Roman List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jan 2004 10:00:41 -0000 >Number: 62102 >Category: kern >Synopsis: obreak update >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Fri Jan 30 02:00:34 PST 2004 >Closed-Date: >Last-Modified: >Originator: Divacky Roman >Release: FreeBSD 5.2-CURRENT i386 >Organization: home >Environment: System: FreeBSD eva.fit.vutbr.cz 4.9-STABLE FreeBSD 4.9-STABLE #2: Thu Nov 20 11:20:53 CET 2003 root@tereza.fit.vutbr.cz:/home/src/sys/sys-49/compile/EVA i386 >Description: A small speed up of obreak() we needlessly lock and unlock vm_map if new==old in obreak() this removes it netbsd and linux does it the same way... not big imporovement but cannot hurt ;) >How-To-Repeat: apply this patch >Fix: --- vm_unix.c Wed Nov 12 20:45:35 2003 +++ vm_unix.c.new Mon Jan 26 15:22:27 2004 @@ -83,10 +83,15 @@ do_map_wirefuture = FALSE; new = round_page((vm_offset_t)uap->nsize); - vm_map_lock(&vm->vm_map); base = round_page((vm_offset_t) vm->vm_daddr); old = base + ctob(vm->vm_dsize); + + if (new == old) + return 0; + + vm_map_lock(&vm->vm_map); + if (new > base) { /* * Check the resource limit, but allow a process to reduce >Release-Note: >Audit-Trail: >Unformatted: