From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Oct 5 13:50:08 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EFA3C106566B for ; Fri, 5 Oct 2012 13:50:07 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C804B8FC08 for ; Fri, 5 Oct 2012 13:50:07 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q95Do7QK059023 for ; Fri, 5 Oct 2012 13:50:07 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q95Do7ad059022; Fri, 5 Oct 2012 13:50:07 GMT (envelope-from gnats) Resent-Date: Fri, 5 Oct 2012 13:50:07 GMT Resent-Message-Id: <201210051350.q95Do7ad059022@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, arrowdodger <6yearold@gmail.com> Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 17480106566C for ; Fri, 5 Oct 2012 13:42:06 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id DCC618FC08 for ; Fri, 5 Oct 2012 13:42:05 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id q95Dg5M5030860 for ; Fri, 5 Oct 2012 13:42:05 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id q95Dg5NN030858; Fri, 5 Oct 2012 13:42:05 GMT (envelope-from nobody) Message-Id: <201210051342.q95Dg5NN030858@red.freebsd.org> Date: Fri, 5 Oct 2012 13:42:05 GMT From: arrowdodger <6yearold@gmail.com> To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/172357: [PATCH] devel/ncurses: Fix build with clang X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2012 13:50:08 -0000 >Number: 172357 >Category: ports >Synopsis: [PATCH] devel/ncurses: Fix build with clang >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Oct 05 13:50:06 UTC 2012 >Closed-Date: >Last-Modified: >Originator: arrowdodger >Release: >Organization: >Environment: >Description: The code in question is quite strange, i didn't get what developers meant with this, so i just silenced compiler with explicit cast. >How-To-Repeat: >Fix: This is a patch for files/ dir. Patch attached with submission follows: diff -ruN c++/cursesm.h_ c++/cursesm.h --- c++/cursesm.h_ 2012-10-05 13:03:04.836549667 +0400 +++ c++/cursesm.h 2012-10-05 13:04:02.611549667 +0400 @@ -639,7 +639,7 @@ const T* p_UserData = STATIC_CAST(T*)(0), bool with_frame=FALSE, bool autoDelete_Items=FALSE) - : NCursesMenu (Items, with_frame, autoDelete_Items) { + : NCursesMenu (reinterpret_cast(Items), with_frame, autoDelete_Items) { if (menu) set_user (const_cast(p_UserData)); }; @@ -651,7 +651,7 @@ int begin_x = 0, const T* p_UserData = STATIC_CAST(T*)(0), bool with_frame=FALSE) - : NCursesMenu (Items, nlines, ncols, begin_y, begin_x, with_frame) { + : NCursesMenu (reinterpret_cast(Items), nlines, ncols, begin_y, begin_x, with_frame) { if (menu) set_user (const_cast(p_UserData)); }; diff -ruN c++/cursesm.h_ c++/cursesm.h --- c++/cursesm.h_ 2012-10-05 13:03:04.836549667 +0400 +++ c++/cursesm.h 2012-10-05 13:04:02.611549667 +0400 @@ -639,7 +639,7 @@ const T* p_UserData = STATIC_CAST(T*)(0), bool with_frame=FALSE, bool autoDelete_Items=FALSE) - : NCursesMenu (Items, with_frame, autoDelete_Items) { + : NCursesMenu (reinterpret_cast(Items), with_frame, autoDelete_Items) { if (menu) set_user (const_cast(p_UserData)); }; @@ -651,7 +651,7 @@ int begin_x = 0, const T* p_UserData = STATIC_CAST(T*)(0), bool with_frame=FALSE) - : NCursesMenu (Items, nlines, ncols, begin_y, begin_x, with_frame) { + : NCursesMenu (reinterpret_cast(Items), nlines, ncols, begin_y, begin_x, with_frame) { if (menu) set_user (const_cast(p_UserData)); }; >Release-Note: >Audit-Trail: >Unformatted: