Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 18 Nov 2018 09:47:40 +0000 (UTC)
From:      Kristof Provost <kp@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r340550 - stable/11/sbin/pfctl
Message-ID:  <201811180947.wAI9leM5075872@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kp
Date: Sun Nov 18 09:47:39 2018
New Revision: 340550
URL: https://svnweb.freebsd.org/changeset/base/340550

Log:
  MFC r339464:
  
  pfctl: Dup strings
  
  When we set the ifname we have to copy the string, rather than just keep
  the pointer.
  
  PR:		231323

Modified:
  stable/11/sbin/pfctl/parse.y
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sbin/pfctl/parse.y
==============================================================================
--- stable/11/sbin/pfctl/parse.y	Sun Nov 18 09:47:30 2018	(r340549)
+++ stable/11/sbin/pfctl/parse.y	Sun Nov 18 09:47:39 2018	(r340550)
@@ -4402,7 +4402,7 @@ route_host	: STRING			{
 			$$ = calloc(1, sizeof(struct node_host));
 			if ($$ == NULL)
 				err(1, "route_host: calloc");
-			$$->ifname = $1;
+			$$->ifname = strdup($1);
 			set_ipmask($$, 128);
 			$$->next = NULL;
 			$$->tail = $$;
@@ -4412,7 +4412,7 @@ route_host	: STRING			{
 
 			$$ = $3;
 			for (n = $3; n != NULL; n = n->next)
-				n->ifname = $2;
+				n->ifname = strdup($2);
 		}
 		;
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201811180947.wAI9leM5075872>