From owner-p4-projects@FreeBSD.ORG  Wed Nov 26 06:55:20 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 6123316A4D2; Wed, 26 Nov 2003 06:55:20 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2C61416A4CE
	for <perforce@freebsd.org>; Wed, 26 Nov 2003 06:55:20 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 86B3D43FE1
	for <perforce@freebsd.org>; Wed, 26 Nov 2003 06:55:19 -0800 (PST)
	(envelope-from areisse@nailabs.com)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.9/8.12.9) with ESMTP id hAQEtJXJ007255
	for <perforce@freebsd.org>; Wed, 26 Nov 2003 06:55:19 -0800 (PST)
	(envelope-from areisse@nailabs.com)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.9/8.12.9/Submit) id hAQEtJjk007248
	for perforce@freebsd.org; Wed, 26 Nov 2003 06:55:19 -0800 (PST)
	(envelope-from areisse@nailabs.com)
Date: Wed, 26 Nov 2003 06:55:19 -0800 (PST)
Message-Id: <200311261455.hAQEtJjk007248@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	areisse@nailabs.com using -f
From: Andrew Reisse <areisse@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 43056 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Nov 2003 14:55:20 -0000

http://perforce.freebsd.org/chv.cgi?CH=43056

Change 43056 by areisse@areisse_ibook on 2003/11/26 06:55:15

	setattrlist() needs a mac check. (getattrlist() should have one also,
	but preventing calls to it greatly confuses the finder)

Affected files ...

.. //depot/projects/trustedbsd/sedarwin/apsl/xnu/bsd/vfs/vfs_syscalls.c#13 edit

Differences ...

==== //depot/projects/trustedbsd/sedarwin/apsl/xnu/bsd/vfs/vfs_syscalls.c#13 (text+ko) ====

@@ -3444,6 +3444,16 @@
 	if (error = namei(&nd))
 		return (error);
 
+#ifdef MAC
+	/* XXX: does not pass mode! */
+	error = mac_check_vnode_setmode(p->p_ucred, nd.ni_vp, 0644);
+	if (error)
+	  {
+	    vput (nd.ni_vp);
+	    return error;
+	  }
+#endif
+
 	/* Set up the UIO structure for use by the vfs routine */
 	aiov.iov_base = uap->attributeBuffer;
 	aiov.iov_len = uap->bufferSize;