From nobody Thu May 23 15:14:56 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VlWtq2qDpz5Ltkk; Thu, 23 May 2024 15:14:59 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VlWtq1z88z4TBx; Thu, 23 May 2024 15:14:59 +0000 (UTC) (envelope-from bapt@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716477299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cPG0YVyvlfMNDbseTC5COIF9T94GZgpLfyBvo+doSNI=; b=AfJ+/rsIxbQ/30kt6uznNhb3xfH6VHJx7y9+gUv3QMbtsVvNzo1OA+gz1A0ffYvHVCG+oe NaY6TuP3Hx+YJ0Bgobt1DcOKOK8LvviL9eIbA+TkWeaGfZuERcNslvkhfabRb+Zrka+fiM lsVvVfJtOTLFrScoGzD6UkU0IzpzwCcsLwN1XtUxFR3kkPCIxHiki8GynNxWDTlejSbY8i wGtYPUDxjKDEHI96KSTrtBmE42q8WvxfiqxzGwy64NKTLUssMm8atSA/OkrnHqTaT57Xa8 gnpjpiuv4j0h6KGLR1nCY+ehucxEO4tn5wDYFahBq/eQucgBX4ZW2Nm/7wLVWQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1716477299; a=rsa-sha256; cv=none; b=qTu/MfQmWjzGjg8w3ERP7Wb/jXQMrmFnvt3kXVrY1eO2nM312lcc4AE420M44O29sar3/M 5qsCGRzfoU4cqdujcmfB3g9NEGlWK4gbZD6MdfHFPG+PrMz0aloEYIvlPo7bPgjRg60rpu 5UIFZ1QOKEUyQNdHPB29+R4oHICuIzoUtkucuaM7OhFpcW9e2VtAyRkS8RvyH/NJNiweaX Qhre4jG+iiE49pcebnvsE3DSJGYqILM4cpgREiwBhpGBEezWNpmlqSModSfaHpIYNCa7XB ETPzYnuNycAgEsCGHM7eTzor1AQw2qZjkbqvxn5wB85jM0pogcsT6PMcDHVc3A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716477299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cPG0YVyvlfMNDbseTC5COIF9T94GZgpLfyBvo+doSNI=; b=sysLlyG7x/jhMc3lZO89rfBL7pzgxBjFMwfQr5byvnbDLHdKApp4QGQBxMgAyD+LqgQUT4 N7r6eY58Xi64kwmnfZWACAGYFxypeD2btR49N4gaOn/bE7kRP6w7CR8XT7NcCwGopGT9bU uF5Vndfc96jQNaebde3S0DKphX48IpFjy1h42NiQs3hseqhqciDuaCroFYkZpXkZLrCWx1 RX78x18iPjguVCLn/Uyx6ln4sBeO+iV5hR3y7+KaV9VCM3NnB1IBmrHfhw4wtQIJm9UBk+ nH1NZaT5S9YQXZBzAmXNh2zbahXkkDznmDsxUVjAn8+wqgXnJPhp7RxnLxEvCQ== Received: from aniel.nours.eu (nours.eu [176.31.115.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VlWtq0p8LzG91; Thu, 23 May 2024 15:14:59 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id C69CD11D69C; Thu, 23 May 2024 17:14:56 +0200 (CEST) Date: Thu, 23 May 2024 17:14:56 +0200 From: Baptiste Daroussin To: Michael Osipov Cc: Mike Karels , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: aa48259f3371 - main - periodic.conf: remove long deprecated security_daily_compat_var() Message-ID: References: <202405030740.4437eWUC034126@gitrepo.freebsd.org> <648BD801-F3C0-40DD-B500-CB71177A6748@karels.net> <61c568fb-7e9d-4445-9d91-0830975bb54b@FreeBSD.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <61c568fb-7e9d-4445-9d91-0830975bb54b@FreeBSD.org> On Thu 23 May 14:34, Michael Osipov wrote: > On 2024-05-23 14:10, Mike Karels wrote: > > On 22 May 2024, at 10:07, Baptiste Daroussin wrote: > > > > > On Fri 03 May 07:40, Michael Osipov wrote: > > > > The branch main has been updated by michaelo: > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=aa48259f337100e79933d660fec8856371f761ed > > > > > > > > commit aa48259f337100e79933d660fec8856371f761ed > > > > Author: Michael Osipov > > > > AuthorDate: 2024-04-15 11:05:17 +0000 > > > > Commit: Michael Osipov > > > > CommitDate: 2024-05-03 07:38:55 +0000 > > > > > > > > periodic.conf: remove long deprecated security_daily_compat_var() > > > > > > > > This function is documented to be gone in after 11. Time to remove this > > > > compat shim. > > > > > > > > PR: 275296 > > > > Reviewed by: jrm (mentor) > > > > MFC after: 1 month > > > > Differential Revision: https://reviews.freebsd.org/D44796 > > > > > > this broke pkg's periodic script, I would have appreciated a heads up to give me > > > time to prepare a release compatible prior this commit. > > > > > > This also breaks some ports. > > > > > > Bapt > > > > This produces almost a dozen failure messages in the daily security email. > > Given that the deprecated function was still in use, it should not be removed. > > Michael, please revert this. > > Salut Baptiste, > Hi Mike, > > this is surprising that is it still in use although clear marked as > deprecated after 11. Though, Baptiste has pushed a new pkg release yesterday > [1] and only main is affected, do you still prefer to revert this commit > (for now)? > > @bapt, can you name the affected ports and report a PR, so we can track > them? > This was in use beside the deprecation, because pkg for one is supposed to support as many version of freebsd as possible so we had to keep the deprecation notice. I have released a new version of pkg without it and merged that version in quarterly branches, so even if it gets MFCed we should be safe. I was scared more ports where keeping for the same reason the deprecated code, I span the ports tree itself and found one port which I fixed straight away, I also did a deep analysis of the any port which plist contains etc/periodic, I extracted all their sources and I found nothing. so I think we are safe now. I don't think we should revert. Best regards, Bapt