From owner-freebsd-stable@FreeBSD.ORG Wed May 31 22:06:51 2006 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5B88816BA06 for ; Wed, 31 May 2006 22:06:51 +0000 (UTC) (envelope-from dmitry@atlantis.dp.ua) Received: from postman.atlantis.dp.ua (postman.atlantis.dp.ua [193.108.47.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 93A6C43D46 for ; Wed, 31 May 2006 22:06:50 +0000 (GMT) (envelope-from dmitry@atlantis.dp.ua) Received: from smtp.atlantis.dp.ua (smtp.atlantis.dp.ua [193.108.46.231]) by postman.atlantis.dp.ua (8.13.1/8.13.1) with ESMTP id k4VM6im6066709; Thu, 1 Jun 2006 01:06:44 +0300 (EEST) (envelope-from dmitry@atlantis.dp.ua) Date: Thu, 1 Jun 2006 01:06:44 +0300 (EEST) From: Dmitry Pryanishnikov To: Konstantin Belousov In-Reply-To: <20060525145809.GP54541@deviant.kiev.zoral.com.ua> Message-ID: <20060530223342.G2710@atlantis.atlantis.dp.ua> References: <001401c67f56$b02975e0$071872cf@Leadmon.local> <003001c67fae$27a88370$071872cf@Leadmon.local> <20060525051926.GB97976@xor.obsecurity.org> <20060525145809.GP54541@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Howard Leadmon , 'Rong-en Fan' , freebsd-stable@freebsd.org, Kris Kennaway Subject: Re: [patch, try 1] Re: Trouble with NFSd under 6.1-Stable, any ideas? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 22:06:52 -0000 Hello! On Thu, 25 May 2006, Konstantin Belousov wrote: > KASSERT(!(debug_mpsafenet == 1 && mtx_owned(&Giant)), > ("nfssvc_nfsd(): debug.mpsafenet=1 && Giant")); > > from nfsserver/nfs_syscalls.c, line 570. > > As I understand the problem, kern/vfs_lookup.c:lookup() could > aquire additional locks on Giant, indicating this by GIANTHELD > flag in nd. All processing in nfsserver already goes with Giant held, > so, I just dropped that excessive locks after return from lookup. > System with patch applied survived smoke test (client did > du on mounted dir, patch was generated from exported fs, etc.). > nfsd eats no more than 25% of CPU (with INVARIANTS). > > Please, users who reported the problem and willing to help, > try the patch (generated against STABLE) and give the feedback. Thank you very much. Your patch actually fixes "nfssvc_nfsd(): debug.mpsafenet=1 && Giant" panic during NFS mount of server's "/usr". Oddly enough, NFS mount of server's "/" doesn't panic the server. My kernel config contains "options QUOTA", however quotas are not enabled. Please commit the fix, IMHO long-term breakage of such a basic functionality (NFS server + quotas) in -STABLE branch isn't a Good Thing (TM). Sincerely, Dmitry -- Atlantis ISP, System Administrator e-mail: dmitry@atlantis.dp.ua nic-hdl: LYNX-RIPE