From owner-freebsd-gnome@freebsd.org Sat Sep 5 06:00:25 2015 Return-Path: Delivered-To: freebsd-gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1C3839CBEDC for ; Sat, 5 Sep 2015 06:00:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 0551690A for ; Sat, 5 Sep 2015 06:00:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 0473D9CBEDB; Sat, 5 Sep 2015 06:00:25 +0000 (UTC) Delivered-To: gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 040A39CBEDA for ; Sat, 5 Sep 2015 06:00:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E8ABA909 for ; Sat, 5 Sep 2015 06:00:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t8560OwW090771 for ; Sat, 5 Sep 2015 06:00:24 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: maintainer-feedback requested: [Bug 202901] games/qqwing configure narrowly searches for gcc or cc and Makefile hard-codes CC CXX CPP plus does not respect CFLAGS Date: Sat, 05 Sep 2015 06:00:24 +0000 X-Bugzilla-Type: request Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Sep 2015 06:00:25 -0000 Kenneth Salerno has reassigned Bugzilla Automation 's request for maintainer-feedback to gnome@FreeBSD.org: Bug 202901: games/qqwing configure narrowly searches for gcc or cc and Makefile hard-codes CC CXX CPP plus does not respect CFLAGS https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202901 --- Description --- QQWing uses a configure script that narrowly searches for literally "gcc" or cc, but will never find "gcc5" or "gcc48" and "g++5" or "g++48" if that is what the user has set his CC CXX and CPP flags to use for ports. On top of that, the port's Makefile hard-codes CC, CXX and CPP to use clang (or gcc 4.2 on FreeBSD version < 10). The configure script should be patched to just use "cc" and "c++" if CC CXX and CPP are not set by the user, which would obsolete the need to hard-code CC CXX CPP flags in the port's Makefile while making it flexible to support gcc5/gcc48 without modification. test -z "$CC" && CC=cc test -z "$CXX" && CXX=c++ Another patch would be required of the automake files to respect CFLAGS (hard-coded to -O2 -g), CXXFLAGS and LDFLAGS but first thing's first, need to respect compiler chosen. The reason I happened upon this issue is because my ports are compiled with gcc5/g++5 and when qqwing got compiled with clang I ran into an ABI incompatibility when linking gnome-sudoku (built with gcc5) forcing me to hack the qqwing configure script to find g++5.