From owner-cvs-src@FreeBSD.ORG Wed Oct 10 17:31:05 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BC7C116A41B; Wed, 10 Oct 2007 17:31:05 +0000 (UTC) (envelope-from mtm@FreeBSD.Org) Received: from terra.mike.lan (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 427CD13C459; Wed, 10 Oct 2007 17:30:24 +0000 (UTC) (envelope-from mtm@FreeBSD.Org) Received: by terra.mike.lan (Postfix, from userid 1000) id 86E9D6780C; Wed, 10 Oct 2007 20:34:09 +0300 (EAT) Date: Wed, 10 Oct 2007 20:34:09 +0300 From: Mike Makonnen To: Dag-Erling Sm??rgrav Message-ID: <20071010173408.GA24022@terra.mike.lan> References: <200710090730.l997UEEF042804@repoman.freebsd.org> <20071010002930.GA91077@dragon.NUXI.org> <86hckzgthr.fsf@ds4.des.no> <86fy0jdn3y.fsf@ds4.des.no> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86fy0jdn3y.fsf@ds4.des.no> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD/7.0-CURRENT (i386) Cc: cvs-src@FreeBSD.org, Doug Barton , cvs-all@FreeBSD.org, obrien@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d early.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Oct 2007 17:31:05 -0000 On Wed, Oct 10, 2007 at 05:07:45PM +0200, Dag-Erling Sm??rgrav wrote: > Dag-Erling Sm??rgrav writes: > > I must confess I don't really see the point of this change. Yes, people > > can write rc.d scripts instead, but not (by far) as easily as they can > > add a line or two to rc.early. > > > > If the problem is that rc.early is sourced by early.sh which is sourced > > by rc, simply rename early.sh to early so it runs in a subshell instead. > > Doug, any chance you can back out your change and apply to have > src/etc/rc.d/early.sh renamed to src/etc/rc.d/early instead? Whatever we end up doing just an FYI that the reason it's a .sh script is because it was sourced directly into the pre-rc.d /etc/rc. If we change it to be sourced in a sub-shell we will break rc.early scripts that define/modify environment variables that later scripts depend on. Cheers. -- Mike Makonnen | GPG-KEY: http://people.freebsd.org/~mtm/mtm.asc mmakonnen @ gmail.com | AC7B 5672 2D11 F4D0 EBF8 5279 5359 2B82 7CD4 1F55 mtm @ FreeBSD.Org | FreeBSD - http://www.freebsd.org