From owner-freebsd-current@FreeBSD.ORG Mon Jun 27 20:52:05 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6C12916A41F for ; Mon, 27 Jun 2005 20:52:05 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id 205BE43D53 for ; Mon, 27 Jun 2005 20:52:05 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from [10.50.41.231] (Not Verified[65.202.103.25]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Mon, 27 Jun 2005 17:05:38 -0400 From: John Baldwin To: freebsd-current@freebsd.org Date: Mon, 27 Jun 2005 16:51:52 -0400 User-Agent: KMail/1.8 References: <20050617173008.A11142@cons.org> <20050624195906.A5702@cons.org> <1119816026.3817.20.camel@leguin> In-Reply-To: <1119816026.3817.20.camel@leguin> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200506271651.54116.jhb@FreeBSD.org> Cc: Martin Cracauer , Eric Anholt , Adam K Kirchhoff , Warner Losh Subject: Re: 6.0-current panic: loading radeon module X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2005 20:52:05 -0000 On Sunday 26 June 2005 04:00 pm, Eric Anholt wrote: > On Fri, 2005-06-24 at 19:59 -0400, Martin Cracauer wrote: > > > I'd forgotten about this thread. I've got a proposed fix for this at: > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/80718 > > > > I get the same panic and backtrace with that patch (on a 32 MB moobile > > Radeon 7500). > > > > I will annotate the sourcecode now to verify (or not) the NULLs in the > > arguments for the bus argument. > > OK, one more try, for everyone who's been having hangs/reboots on X > startup since April. Attached is a patch that will hopefully kill the > problem off. It would probably be best to use bus_alloc_resource() without RF_ACTIVE set as otherwise you'll get a base address of 0 using the bus_get_resource() method if the BAR hasn't been mapped yet (e.g., this isn't a boot display device). Also, please use 'rid = PCIR_BAR(resource)' rather than 'rid = resource * 4 + 0x10' as that's probably a lot clearer way of saying that you are mapping BAR 'resource'. You can also still alloc the framebuffer resource in your last hunk, just don't set RF_ACTIVE for the framebuffer but do set it for the mmio registers. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org