From owner-freebsd-current@FreeBSD.ORG Mon Oct 17 20:13:17 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 76254106566B; Mon, 17 Oct 2011 20:13:17 +0000 (UTC) (envelope-from lacombar@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id D4C778FC15; Mon, 17 Oct 2011 20:13:16 +0000 (UTC) Received: by wwi18 with SMTP id 18so3662792wwi.31 for ; Mon, 17 Oct 2011 13:13:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=xeefVTxrIqjKpKr05FHotIjSxrfFT8kISsE8oOu8/Fo=; b=po3wboaZt7ttftKGhC8gS/dQmlIxZGGXo7I/dn3ziSQoPUNZORPOxYtF7oteTX64Tw /by2lyEY9hWWhdo+R4/e1rNWIRBYQAwS3+VCmdHgLJ52Lx7VTp9mXgfgtSH0Qsf6A7lm mVLslXI0erzvpT3aUaEKuDlRa9XpDFIAMtrBI= MIME-Version: 1.0 Received: by 10.216.133.5 with SMTP id p5mr4382786wei.34.1318882395332; Mon, 17 Oct 2011 13:13:15 -0700 (PDT) Received: by 10.180.103.198 with HTTP; Mon, 17 Oct 2011 13:13:15 -0700 (PDT) In-Reply-To: References: <20111014085609.GA3799@freebsd.org> <40448.1318582809@critter.freebsd.dk> <20111014092445.GA11785@freebsd.org> <20111014093406.GA13981@freebsd.org> <8662jrlor0.fsf@gmail.com> <20111017180111.GA91732@freebsd.org> Date: Mon, 17 Oct 2011 16:13:15 -0400 Message-ID: From: Arnaud Lacombe To: Garrett Cooper Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Nali Toja , Alexander Best , Poul-Henning Kamp , FreeBSD Current , Nikolay Denev Subject: Re: [RFC] Prepend timestamp in msgbuf X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2011 20:13:17 -0000 Hi, On Mon, Oct 17, 2011 at 3:38 PM, Garrett Cooper wrote: > On Mon, Oct 17, 2011 at 12:27 PM, Arnaud Lacombe wro= te: >> Hi, >> >> On Mon, Oct 17, 2011 at 2:01 PM, Alexander Best wr= ote: >>> On Fri Oct 14 11, Arnaud Lacombe wrote: >>> [...] >>> >>> cc -c -O -pipe -march=3Dcore2 -std=3Dc99 -g -Wall -Wredundant-decls -Wn= ested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Win= line -Wcast-qual -Wundef -Wno-pointer-sign -Wmissing-include-dirs -nostdinc= =A0-I. -I/usr/git-freebsd-head/sys -I/usr/git-freebsd-head/sys/contrib/alt= q -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common = -finline-limit=3D8000 --param inline-unit-growth=3D100 --param large-functi= on-growth=3D1000 =A0-fno-omit-frame-pointer -mno-sse -mcmodel=3Dkernel -mno= -red-zone -mno-mmx -msoft-float -fno-asynchronous-unwind-tables -ffreestand= ing -fformat-extensions -fdiagnostics-show-option -fstack-protector -Werror= =A0/usr/git-freebsd-head/sys/kern/subr_msgbuf.c >>> cc1: warnings being treated as errors >>> /usr/git-freebsd-head/sys/kern/subr_msgbuf.c: In function 'msgbuf_do_ad= dchar': >>> /usr/git-freebsd-head/sys/kern/subr_msgbuf.c:171: warning: format '%d' = expects type 'int', but argument 4 has type 'time_t' [-Wformat] >>> *** Error code 1 >>> >>> Stop in /usr/obj/usr/git-freebsd-head/sys/ARUNDEL. >>> *** Error code 1 >>> >>> Stop in /usr/git-freebsd-head. >>> *** Error code 1 >>> >>> Stop in /usr/git-freebsd-head. >>> >> FreeBSD has no time_t PRI... macros in any , >> eventually cast it to `long'. >> >> Btw, I appreciate the very clear message of yours, no "Hi", no >> signature, no idea what "ARUNDEL" is, and especially no details on >> which architecture you are attempting to build, which should be, I >> assume, LP64 ;-) > > =A0 =A0time_t maps to int32_t on i386 and int64_t on amd64 (at least), so > you should be able to use "%zd" in the format string as the type is > variable width depending on the architecture. > make sense. Thanks, - Arnaud