From owner-freebsd-apache@FreeBSD.ORG  Wed Jan  8 21:40:47 2014
Return-Path: <owner-freebsd-apache@FreeBSD.ORG>
Delivered-To: apache@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 4AA6C5E4
 for <apache@FreeBSD.org>; Wed,  8 Jan 2014 21:40:47 +0000 (UTC)
Received: from mout.gmx.net (mout.gmx.net [212.227.15.19])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id D5838152F
 for <apache@FreeBSD.org>; Wed,  8 Jan 2014 21:40:46 +0000 (UTC)
Received: from [192.168.0.100] ([87.139.233.65]) by mail.gmx.com (mrgmx001)
 with ESMTPSA (Nemesis) id 0MFcg9-1WCspt3Uv7-00EccC for <apache@FreeBSD.org>;
 Wed, 08 Jan 2014 22:40:44 +0100
Message-ID: <52CDC5DC.8010703@gmx.de>
Date: Wed, 08 Jan 2014 22:40:44 +0100
From: olli hauer <ohauer@gmx.de>
User-Agent: Mozilla/5.0 (Windows NT 5.1;
 rv:24.0) Gecko/20100101 Thunderbird/24.2.0
MIME-Version: 1.0
To: bug-followup@FreeBSD.org, portmaster@bsdforge.com
Subject: Re: ports/185585: [PATCH] www/mod_log_mysql - new MASTER_SITES, new
 maintainer, new version
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:P+cz27W+FSyU3yv6YanIxOAt4fHtuCzZgXEXyP/nRmFVp9axuRc
 r7H2UxM43nxgPNQgsuxD1nACvAEE0HVjk5CHrGHyHRFUp3KV6HJjZZbhzfiRRln+1VJV2us
 y3VAVgGmJqBsx9PSsv9i+cS9HDmEHI4Ht/iZlAQeDUJmBPTurYspGJrY/nPMAfsT6twfs5Q
 ubsuzr7fDFAgJbpcSAmVQ==
Cc: C Hutchinson <portmaster@bsdforge.com>,
 "apache@FreeBSD.org" <apache@FreeBSD.org>
X-BeenThere: freebsd-apache@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Support of apache-related ports  <freebsd-apache.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-apache>,
 <mailto:freebsd-apache-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-apache/>
List-Post: <mailto:freebsd-apache@freebsd.org>
List-Help: <mailto:freebsd-apache-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-apache>,
 <mailto:freebsd-apache-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jan 2014 21:40:47 -0000

Hi C. Hutchinson,

some questions / remarks.

Using the command `diff -nruw' I see no no code addition / improvement

However, you have changed the original license and and added your name
and  BSDforge as additional Copyright holder.

- * Copyright 2003 Sönke Tesch. All rights reserved.
- * Version 20031023
+ * Copyright 2003 Sönke Tesch. All rights reserved.
+ * Copyright 2014 C Hutchinson, All rights reserved.

Some reasons why I additional dislike the License change:

+ * 4. Neither the name of BSDforge, nor the names of its contributors
+ *    may be used to endorse or promote products derived from this
+ *    software without specific prior written permission.
+ *
...
- * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
+ * THIS SOFTWARE IS PROVIDED BY THE PERLWATCH ORGANIZATION ''AS IS'' AND


My personal opinion:

I see no code improvements that allows such Lic. changes (cleanup whites paces
and using iconv to convert a file from ISO-8859 to UTF-8 was never a reason to
add an individual to the Copyright or allow to change the License terms.

I have contacted the original src. Author from mod_log_mysql, so please
be patient and stay tuned until I have feedback from Sönke.

-- 
Regards,
olli