From owner-cvs-all@FreeBSD.ORG Sat Apr 26 09:02:34 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 71B1B37B401; Sat, 26 Apr 2003 09:02:34 -0700 (PDT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id B0D6A43F93; Sat, 26 Apr 2003 09:02:33 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.9/8.12.9) with ESMTP id h3QG2QsU013170; Sat, 26 Apr 2003 09:02:26 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.9/8.12.9/Submit) id h3QG2QFa013169; Sat, 26 Apr 2003 09:02:26 -0700 (PDT) Date: Sat, 26 Apr 2003 09:02:25 -0700 From: "David O'Brien" To: Hartmut Brandt Message-ID: <20030426160225.GA8241@dragon.nuxi.com> References: <200304251614.h3PGE3t5006537@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200304251614.h3PGE3t5006537@repoman.freebsd.org> User-Agent: Mutt/1.4i X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/modules Makefile src/sys/pci if_en_pci.c src/sys/modules/en Makefile src/sys/dev/en midway.c midwayreg.h midwayvar.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Apr 2003 16:02:35 -0000 On Fri, Apr 25, 2003 at 09:14:03AM -0700, Hartmut Brandt wrote: > Modified files: > sys/modules Makefile > sys/pci if_en_pci.c > sys/dev/en midway.c midwayreg.h midwayvar.h > Added files: > sys/modules/en Makefile > Log: > Convert the midway driver to use busdma. Except for this conversion the > following changes have been done: > > - stylify. The original code was too hard to read. > - get rid of a number of compilation options (Adaptec-only, Eni-only, no-DMA). > - more debugging features. > - locking. This is not correct yet in the absence of interface layer locking, Were you not aware we have rules against exactly this type of commit?? It is totally impossible to tell what the real changes were and which the style changes were. Please don't make a commits like this again.