From owner-freebsd-current@freebsd.org Tue Dec 22 18:27:43 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 93692A4F254 for ; Tue, 22 Dec 2015 18:27:43 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x232.google.com (mail-pf0-x232.google.com [IPv6:2607:f8b0:400e:c00::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 63C6C126E; Tue, 22 Dec 2015 18:27:43 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x232.google.com with SMTP id q63so4051766pfb.0; Tue, 22 Dec 2015 10:27:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=SSMTOtyYaMpVq2aBimBisqVQO2lRezTn7+m5OcswtI0=; b=bP2Ifv5sbsk5Z2sGCgpciY9ptI6IGNcLAd0H4VZbmnze2aLogp9MBjnc+jhOcrBX7N 6HFQwipygAeGMfUSFPeyzZDfPyR3VI2m6Vyf3v++HmqS045ozGcvnof3qBBsFbg8FQO1 mRkycGNf0WC5GGkevu0sAPruDcPLheBX6HB37bKPP0dGEiFEmab7tthgNRDzQ0uJju58 LEmlJWSJDYbCeq5apHbP02mi4W22MZyBc3oxc1m7+OMuVll6x/BBX+FYQezphbOBPKLG dLkFMsZbYRRm6MKXaDbWUznGifuxgtr7Uaz3V17catFV/3ZLhxcxEL72QmzrAInBujJO GseA== X-Received: by 10.98.42.205 with SMTP id q196mr37799571pfq.74.1450808863013; Tue, 22 Dec 2015 10:27:43 -0800 (PST) Received: from [192.168.20.11] (c-24-16-212-205.hsd1.wa.comcast.net. [24.16.212.205]) by smtp.gmail.com with ESMTPSA id q8sm45612414pap.45.2015.12.22.10.27.41 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 22 Dec 2015 10:27:41 -0800 (PST) Content-Type: text/plain; charset=cp932 Mime-Version: 1.0 (1.0) Subject: Re: Build from 9.3-RELEASE to 11.0-CURRENT fails for i386 (-Wsign-compare issues with gcc) From: Garrett Cooper X-Mailer: iPhone Mail (13C75) In-Reply-To: <3216653.gTnkE43ffA@ralph.baldwin.cx> Date: Tue, 22 Dec 2015 10:27:40 -0800 Cc: freebsd-current@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <8E98A82D-C36F-4863-8BE4-81288735F3A1@gmail.com> <3659799.xE9v788p8Q@ralph.baldwin.cx> <3216653.gTnkE43ffA@ralph.baldwin.cx> To: John Baldwin X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Dec 2015 18:27:43 -0000 > On Dec 22, 2015, at 08:23, John Baldwin wrote: >=20 >> On Monday, December 21, 2015 11:01:36 AM John Baldwin wrote: >>> On Saturday, December 19, 2015 01:05:36 PM NGie Cooper wrote: >>> Hi John, >>> I tried bootstrapping 9.3-RELEASE to 11.0-CURRENT with i386 and ran i= nto the -Wsign-compare issue below when running make libraries with buildwor= ld, because it=81fs building libkvm with gcc 4.2.1 :/=81c I=81fve tried boot= strapping with clang/clang37, but haven=81ft been able to yet. I=81fll try i= nstalling 10.2-RELEASE via freebsd-update so I can use clang instead of gcc.= >>> Thanks! >>> -NGie >>=20 >> We don't actually support going from 9 to 11. However, these constants >> should probably be explicitly unsigned anyway. I haven't tested this at >> all, but something like this: >>=20 >> Index: head/lib/libkvm/kvm_i386.h >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- head/lib/libkvm/kvm_i386.h (revision 292553) >> +++ head/lib/libkvm/kvm_i386.h (working copy) >> @@ -57,8 +57,8 @@ >> #define I386_PG_PS 0x080 >> #define I386_PG_FRAME_PAE (0x000ffffffffff000ull) >> #define I386_PG_PS_FRAME_PAE (0x000fffffffe00000ull) >> -#define I386_PG_FRAME (0xfffff000) >> -#define I386_PG_PS_FRAME (0xffc00000) >> +#define I386_PG_FRAME (0xfffff000u) >> +#define I386_PG_PS_FRAME (0xffc00000u) >>=20 >> #ifdef __i386__ >> _Static_assert(PAGE_SHIFT =3D=3D I386_PAGE_SHIFT, "PAGE_SHIFT mismatch");= >=20 > This passed a universe build on HEAD. If you can test that it fixes the 9= .3 -> 11.0 > bootstrap I will commit it. I'll fire up a 9.3 VM and give it a shot. Thanks :)!! -NGie=